Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2034523003: Fix failure in mjsunit/wasm/embenchen/lua_binarytrees on 32-bit architectures (Closed)

Created:
4 years, 6 months ago by ivica.bogosavljevic
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix failure in mjsunit/wasm/embenchen/lua_binarytrees on 32-bit architectures that do not support unaligned access. This test fails because WasmGraphBuilder::BuildCFuncInstruction allocates space for doubles using StackSlot turbofan operator, but this space is not guaranteed to be 8 bytes aligned if SP itself is not 8 bytes aligned (which is the case on 32-bit architectures). BUG=mjsunit/wasm/embenchen/lua_binarytrees Committed: https://crrev.com/f6d47317a096cb78d3f359e242df62af789263ab Cr-Commit-Position: refs/heads/master@{#36693}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -14 lines) Patch
M src/assembler.cc View 5 chunks +32 lines, -14 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
ivica.bogosavljevic
PTAL
4 years, 6 months ago (2016-06-02 10:07:19 UTC) #2
Ilija.Pavlovic1
lgtm
4 years, 6 months ago (2016-06-02 10:45:13 UTC) #4
Ilija.Pavlovic1
lgtm
4 years, 6 months ago (2016-06-02 10:45:14 UTC) #5
balazs.kilvady
lgtm, This does need a v8-team review, please take a look.
4 years, 6 months ago (2016-06-02 11:59:50 UTC) #7
Benedikt Meurer
LGTM.
4 years, 6 months ago (2016-06-02 13:03:06 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2034523003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2034523003/1
4 years, 6 months ago (2016-06-02 14:22:16 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-02 14:49:29 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2034523003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2034523003/1
4 years, 6 months ago (2016-06-03 07:35:10 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-03 07:39:36 UTC) #15
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 07:42:13 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f6d47317a096cb78d3f359e242df62af789263ab
Cr-Commit-Position: refs/heads/master@{#36693}

Powered by Google App Engine
This is Rietveld 408576698