Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Issue 2034493002: [Interpreter] Add intrinsics for Is<Type> calls. (Closed)

Created:
4 years, 6 months ago by rmcilroy
Modified:
4 years, 6 months ago
Reviewers:
mythria
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Add intrinsics for Is<Type> calls. Add intrinsics for IsSmi, IsTypedArray, IsRegExp and IsJSProxy, all of which are intrinsics in Full-Codegen. BUG=v8:4280 LOG=N Committed: https://crrev.com/f4cf05fc0173259565972e50d7de093e18b3867c Cr-Commit-Position: refs/heads/master@{#36707}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add non-smi int to test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+183 lines, -23 lines) Patch
M src/interpreter/interpreter-intrinsics.h View 3 chunks +9 lines, -2 lines 0 comments Download
M src/interpreter/interpreter-intrinsics.cc View 3 chunks +75 lines, -21 lines 0 comments Download
M test/cctest/interpreter/test-interpreter-intrinsics.cc View 1 1 chunk +99 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2034493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2034493002/1
4 years, 6 months ago (2016-06-01 22:27:08 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-01 22:55:07 UTC) #4
rmcilroy
Mythri, ptal, thanks.
4 years, 6 months ago (2016-06-02 08:37:53 UTC) #6
mythria
lgtm. https://codereview.chromium.org/2034493002/diff/1/test/cctest/interpreter/test-interpreter-intrinsics.cc File test/cctest/interpreter/test-interpreter-intrinsics.cc (right): https://codereview.chromium.org/2034493002/diff/1/test/cctest/interpreter/test-interpreter-intrinsics.cc#newcode188 test/cctest/interpreter/test-interpreter-intrinsics.cc:188: CHECK_EQ(*factory->true_value(), *helper.Invoke(helper.NewObject("42"))); May be one more with an ...
4 years, 6 months ago (2016-06-02 10:02:40 UTC) #7
rmcilroy
https://codereview.chromium.org/2034493002/diff/1/test/cctest/interpreter/test-interpreter-intrinsics.cc File test/cctest/interpreter/test-interpreter-intrinsics.cc (right): https://codereview.chromium.org/2034493002/diff/1/test/cctest/interpreter/test-interpreter-intrinsics.cc#newcode188 test/cctest/interpreter/test-interpreter-intrinsics.cc:188: CHECK_EQ(*factory->true_value(), *helper.Invoke(helper.NewObject("42"))); On 2016/06/02 10:02:40, mythria wrote: > May ...
4 years, 6 months ago (2016-06-03 10:17:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2034493002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2034493002/20001
4 years, 6 months ago (2016-06-03 10:17:51 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-03 10:54:15 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 10:56:08 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f4cf05fc0173259565972e50d7de093e18b3867c
Cr-Commit-Position: refs/heads/master@{#36707}

Powered by Google App Engine
This is Rietveld 408576698