Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2034473004: Revert "Compress .pak resources with new option: "type=GZIPPABLE_BINDATA"" (Closed)

Created:
4 years, 6 months ago by xdai1
Modified:
4 years, 6 months ago
Reviewers:
smaier
CC:
chromium-reviews, vabr+watchlistpasswordmanager_chromium.org, jam, darin-cc_chromium.org, arv+watch_chromium.org, gcasto+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Compress .pak resources with new option: "type=GZIPPABLE_BINDATA"" This reverts commit e3a06a21aa1a7adfaef988488cdbcccbfa9a2ef6. This CL breaks all PFQ at the BuildPackages stage. See the infomational builder https://uberchromegw.corp.google.com/i/chromeos.chrome/builders/lumpy-tot-chrome-pfq-informational/builds/19533 as an example. TBR=smaier@chromium.org BUG=616798 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://chromium.googlesource.com/chromium/src/+/49624437b555e0020e0addf2b3c8499b9574e376

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -368 lines) Patch
M chrome/browser/browser_resources.grd View 2 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/resources/net_internals_resources.grd View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/password_manager_internals_resources.grd View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/translate_internals_resources.grd View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/data/webui/webui_resource_browsertest.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M components/resources/gcm_driver_resources.grdp View 1 chunk +3 lines, -3 lines 0 comments Download
M components/resources/signin_resources.grdp View 1 chunk +2 lines, -3 lines 0 comments Download
M content/content_resources.grd View 2 chunks +15 lines, -15 lines 0 comments Download
M content/public/test/browser_test_utils.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M tools/grit/grit/exception.py View 2 chunks +1 line, -4 lines 0 comments Download
M tools/grit/grit/format/data_pack_unittest.py View 2 chunks +0 lines, -34 lines 0 comments Download
D tools/grit/grit/format/gzip_string.py View 1 chunk +0 lines, -43 lines 0 comments Download
D tools/grit/grit/format/gzip_string_unittest.py View 1 chunk +0 lines, -62 lines 0 comments Download
M tools/grit/grit/node/include.py View 4 chunks +4 lines, -26 lines 0 comments Download
M tools/grit/grit/node/include_unittest.py View 2 chunks +1 line, -16 lines 0 comments Download
M tools/grit/grit/test_suite_all.py View 2 chunks +0 lines, -2 lines 0 comments Download
D tools/grit/grit/testdata/test_text.txt View 1 chunk +0 lines, -1 line 0 comments Download
M ui/base/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ui/base/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M ui/base/resource/resource_bundle.h View 3 chunks +1 line, -12 lines 0 comments Download
M ui/base/resource/resource_bundle.cc View 5 chunks +25 lines, -79 lines 0 comments Download
M ui/base/resource/resource_bundle_unittest.cc View 2 chunks +0 lines, -39 lines 0 comments Download
M ui/base/ui_base.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/49624437b555e0020e0addf2b3c8499b9574e376 Cr-Commit-Position: refs/heads/master@{#397455}
4 years, 6 months ago (2016-06-02 17:22:05 UTC) #3
xdai1
Committed patchset #1 (id:1) manually as 49624437b555e0020e0addf2b3c8499b9574e376.
4 years, 6 months ago (2016-06-02 17:23:03 UTC) #5
smaier
4 years, 6 months ago (2016-06-02 20:40:40 UTC) #6
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2036633003/ by smaier@chromium.org.

The reason for reverting is: Do not review.

Powered by Google App Engine
This is Rietveld 408576698