Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Unified Diff: pkg/analyzer/lib/src/context/context.dart

Issue 2034473002: Delay 'supertype' for ClassElementImpl and EnumElementImpl. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analyzer/lib/src/dart/element/element.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/context/context.dart
diff --git a/pkg/analyzer/lib/src/context/context.dart b/pkg/analyzer/lib/src/context/context.dart
index 23cae4a19f758d42274dfcd27ce07939dd07b9c8..97f5f2dfbf2033006c7f3baaac7a211694dff7c8 100644
--- a/pkg/analyzer/lib/src/context/context.dart
+++ b/pkg/analyzer/lib/src/context/context.dart
@@ -466,10 +466,6 @@ class AnalysisContextImpl implements InternalAnalysisContext {
@override
TypeProvider get typeProvider {
- // Make sure a task didn't accidentally try to call back into the context
- // to retrieve the type provider.
- assert(!driver.isTaskRunning);
Brian Wilkerson 2016/06/01 22:23:28 Instead of removing this completely, would it work
Paul Berry 2016/06/01 22:25:55 +1 to this. The reason we added this check in the
scheglov 2016/06/02 00:20:40 That's a great idea. Thank you! Done.
-
if (_typeProvider != null) {
return _typeProvider;
}
« no previous file with comments | « no previous file | pkg/analyzer/lib/src/dart/element/element.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698