Delay 'supertype' for ClassElementImpl and EnumElementImpl.

Delay 'supertype' for ClassElementImpl and EnumElementImpl.

This requires "unbanning" AnalysisContext.typeProvider access during
analysis to make 'supertype' lazy. We can make it lazy for summaries
by using ResynthesizerContext, but for non-summary case there is no
other way.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/18d296261a155d9dc70b963e5bf9558f173d7d6b

[Brian Wilkerson, 2016-06-01 22:23:29]

Other than the one question, lgtm.

https://codereview.chromium.org/2034473002/diff/1/pkg/analyzer/lib/src/contex...
File pkg/analyzer/lib/src/context/context.dart (left):

https://codereview.chromium.org/2034473002/diff/1/pkg/analyzer/lib/src/contex...
pkg/analyzer/lib/src/context/context.dart:471: assert(!driver.isTaskRunning);
Instead of removing this completely, would it work to move it after the null
check on line 472, and then ensure that any tasks that might be asking for the
supertype require the type provider?

[Paul Berry, 2016-06-01 22:25:55]

lgtm

https://codereview.chromium.org/2034473002/diff/1/pkg/analyzer/lib/src/contex...
File pkg/analyzer/lib/src/context/context.dart (left):

https://codereview.chromium.org/2034473002/diff/1/pkg/analyzer/lib/src/contex...
pkg/analyzer/lib/src/context/context.dart:471: assert(!driver.isTaskRunning);
On 2016/06/01 22:23:28, Brian Wilkerson wrote:
> Instead of removing this completely, would it work to move it after the null
> check on line 472, and then ensure that any tasks that might be asking for the
> supertype require the type provider?

+1 to this.  The reason we added this check in the first place was to avoid
reentrancy into the task manager, and I would like to make sure we are still
successfully avoiding that :)

[scheglov, 2016-06-02 00:20:12]

Description was changed from

==========
Delay 'supertype' for ClassElementImpl and EnumElementImpl.

This requires "unbanning" AnalysisContext.typeProvider access during
analysis to make 'supertype' lazy. We can make it lazy for summaries
by using ResynthesizerContext, but for non-summary case there is no
other way.

R=brianwilkerson@google.com, paulberry@google.com
BUG=
==========

to

==========
Delay 'supertype' for ClassElementImpl and EnumElementImpl.

This requires "unbanning" AnalysisContext.typeProvider access during
analysis to make 'supertype' lazy. We can make it lazy for summaries
by using ResynthesizerContext, but for non-summary case there is no
other way.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/18d296261a155d9dc70b963e5bf9558f173d7d6b
==========

[scheglov, 2016-06-02 00:20:13]

Committed patchset #1 (id:1) manually as
18d296261a155d9dc70b963e5bf9558f173d7d6b (presubmit successful).

[scheglov, 2016-06-02 00:20:40]

https://codereview.chromium.org/2034473002/diff/1/pkg/analyzer/lib/src/contex...
File pkg/analyzer/lib/src/context/context.dart (left):

https://codereview.chromium.org/2034473002/diff/1/pkg/analyzer/lib/src/contex...
pkg/analyzer/lib/src/context/context.dart:471: assert(!driver.isTaskRunning);
On 2016/06/01 22:23:28, Brian Wilkerson wrote:
> Instead of removing this completely, would it work to move it after the null
> check on line 472, and then ensure that any tasks that might be asking for the
> supertype require the type provider?

That's a great idea.
Thank you!
Done.