Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Side by Side Diff: Source/devtools/front_end/ObjectPropertiesSection.js

Issue 203443010: DevTools: [JsDocValidator] Fix checking of receivers specified as arguments (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Add a suppression hint message Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2008 Apple Inc. All Rights Reserved.
3 * Copyright (C) 2009 Joseph Pecoraro 3 * Copyright (C) 2009 Joseph Pecoraro
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 722 matching lines...) Expand 10 before | Expand all | Expand 10 after
733 * @param {number} fromIndex 733 * @param {number} fromIndex
734 * @param {number} toIndex 734 * @param {number} toIndex
735 * @param {boolean} topLevel 735 * @param {boolean} topLevel
736 * @this {WebInspector.ArrayGroupingTreeElement} 736 * @this {WebInspector.ArrayGroupingTreeElement}
737 */ 737 */
738 WebInspector.ArrayGroupingTreeElement._populateRanges = function(treeElement, ob ject, fromIndex, toIndex, topLevel) 738 WebInspector.ArrayGroupingTreeElement._populateRanges = function(treeElement, ob ject, fromIndex, toIndex, topLevel)
739 { 739 {
740 object.callFunctionJSON(packRanges, [{value: fromIndex}, {value: toIndex}, { value: WebInspector.ArrayGroupingTreeElement._bucketThreshold}, {value: WebInspe ctor.ArrayGroupingTreeElement._sparseIterationThreshold}], callback); 740 object.callFunctionJSON(packRanges, [{value: fromIndex}, {value: toIndex}, { value: WebInspector.ArrayGroupingTreeElement._bucketThreshold}, {value: WebInspe ctor.ArrayGroupingTreeElement._sparseIterationThreshold}], callback);
741 741
742 /** 742 /**
743 * @suppressReceiverCheck
743 * @this {Object} 744 * @this {Object}
744 * @param {number=} fromIndex // must declare optional 745 * @param {number=} fromIndex // must declare optional
745 * @param {number=} toIndex // must declare optional 746 * @param {number=} toIndex // must declare optional
746 * @param {number=} bucketThreshold // must declare optional 747 * @param {number=} bucketThreshold // must declare optional
747 * @param {number=} sparseIterationThreshold // must declare optional 748 * @param {number=} sparseIterationThreshold // must declare optional
748 */ 749 */
749 function packRanges(fromIndex, toIndex, bucketThreshold, sparseIterationThre shold) 750 function packRanges(fromIndex, toIndex, bucketThreshold, sparseIterationThre shold)
750 { 751 {
751 var ownPropertyNames = null; 752 var ownPropertyNames = null;
752 753
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
832 * @param {!WebInspector.RemoteObject} object 833 * @param {!WebInspector.RemoteObject} object
833 * @param {number} fromIndex 834 * @param {number} fromIndex
834 * @param {number} toIndex 835 * @param {number} toIndex
835 * @this {WebInspector.ArrayGroupingTreeElement} 836 * @this {WebInspector.ArrayGroupingTreeElement}
836 */ 837 */
837 WebInspector.ArrayGroupingTreeElement._populateAsFragment = function(treeElement , object, fromIndex, toIndex) 838 WebInspector.ArrayGroupingTreeElement._populateAsFragment = function(treeElement , object, fromIndex, toIndex)
838 { 839 {
839 object.callFunction(buildArrayFragment, [{value: fromIndex}, {value: toIndex }, {value: WebInspector.ArrayGroupingTreeElement._sparseIterationThreshold}], pr ocessArrayFragment.bind(this)); 840 object.callFunction(buildArrayFragment, [{value: fromIndex}, {value: toIndex }, {value: WebInspector.ArrayGroupingTreeElement._sparseIterationThreshold}], pr ocessArrayFragment.bind(this));
840 841
841 /** 842 /**
843 * @suppressReceiverCheck
842 * @this {Object} 844 * @this {Object}
843 * @param {number=} fromIndex // must declare optional 845 * @param {number=} fromIndex // must declare optional
844 * @param {number=} toIndex // must declare optional 846 * @param {number=} toIndex // must declare optional
845 * @param {number=} sparseIterationThreshold // must declare optional 847 * @param {number=} sparseIterationThreshold // must declare optional
846 */ 848 */
847 function buildArrayFragment(fromIndex, toIndex, sparseIterationThreshold) 849 function buildArrayFragment(fromIndex, toIndex, sparseIterationThreshold)
848 { 850 {
849 var result = Object.create(null); 851 var result = Object.create(null);
850 if (toIndex - fromIndex < sparseIterationThreshold) { 852 if (toIndex - fromIndex < sparseIterationThreshold) {
851 for (var i = fromIndex; i <= toIndex; ++i) { 853 for (var i = fromIndex; i <= toIndex; ++i) {
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
894 896
895 /** 897 /**
896 * @param {!TreeElement|!TreeOutline} treeElement 898 * @param {!TreeElement|!TreeOutline} treeElement
897 * @param {!WebInspector.RemoteObject} object 899 * @param {!WebInspector.RemoteObject} object
898 * @this {WebInspector.ArrayGroupingTreeElement} 900 * @this {WebInspector.ArrayGroupingTreeElement}
899 */ 901 */
900 WebInspector.ArrayGroupingTreeElement._populateNonIndexProperties = function(tre eElement, object) 902 WebInspector.ArrayGroupingTreeElement._populateNonIndexProperties = function(tre eElement, object)
901 { 903 {
902 object.callFunction(buildObjectFragment, undefined, processObjectFragment.bi nd(this)); 904 object.callFunction(buildObjectFragment, undefined, processObjectFragment.bi nd(this));
903 905
904 /** @this {Object} */ 906 /**
907 * @suppressReceiverCheck
908 * @this {Object}
909 */
905 function buildObjectFragment() 910 function buildObjectFragment()
906 { 911 {
907 var result = Object.create(this.__proto__); 912 var result = Object.create(this.__proto__);
908 var names = Object.getOwnPropertyNames(this); 913 var names = Object.getOwnPropertyNames(this);
909 for (var i = 0; i < names.length; ++i) { 914 for (var i = 0; i < names.length; ++i) {
910 var name = names[i]; 915 var name = names[i];
911 // Array index check according to the ES5-15.4. 916 // Array index check according to the ES5-15.4.
912 if (String(name >>> 0) === name && name >>> 0 !== 0xffffffff) 917 if (String(name >>> 0) === name && name >>> 0 !== 0xffffffff)
913 continue; 918 continue;
914 var descriptor = Object.getOwnPropertyDescriptor(this, name); 919 var descriptor = Object.getOwnPropertyDescriptor(this, name);
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
981 { 986 {
982 WebInspector.TextPrompt.call(this, WebInspector.runtimeModel.completionsForT extPrompt.bind(WebInspector.runtimeModel)); 987 WebInspector.TextPrompt.call(this, WebInspector.runtimeModel.completionsForT extPrompt.bind(WebInspector.runtimeModel));
983 this.setSuggestBoxEnabled("generic-suggest"); 988 this.setSuggestBoxEnabled("generic-suggest");
984 if (renderAsBlock) 989 if (renderAsBlock)
985 this.renderAsBlock(); 990 this.renderAsBlock();
986 } 991 }
987 992
988 WebInspector.ObjectPropertyPrompt.prototype = { 993 WebInspector.ObjectPropertyPrompt.prototype = {
989 __proto__: WebInspector.TextPrompt.prototype 994 __proto__: WebInspector.TextPrompt.prototype
990 } 995 }
OLDNEW
« no previous file with comments | « Source/devtools/front_end/ElementsTreeOutline.js ('k') | Source/devtools/front_end/PropertiesSidebarPane.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698