Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 203443004: use new readPixels, as old version using Config8888 is deprecated (Closed)

Created:
6 years, 9 months ago by reed1
Modified:
6 years, 9 months ago
CC:
blink-reviews, jamesr, krit, dsinclair, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

use new readPixels, as old version using Config8888 is deprecated BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169754

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : return the image buffer, even if readPixels fails #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -15 lines) Patch
M Source/platform/graphics/GraphicsContext.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/GraphicsContext.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/graphics/ImageBuffer.cpp View 1 2 1 chunk +3 lines, -12 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
reed1
will need todays DEPS roll to get new API
6 years, 9 months ago (2014-03-18 15:55:45 UTC) #1
f(malita)
lgtm https://codereview.chromium.org/203443004/diff/1/Source/platform/graphics/ImageBuffer.cpp File Source/platform/graphics/ImageBuffer.cpp (right): https://codereview.chromium.org/203443004/diff/1/Source/platform/graphics/ImageBuffer.cpp#newcode279 Source/platform/graphics/ImageBuffer.cpp:279: SkAlphaType = (multiplied == Premultiplied) ? kPremul_SkAlphaType : ...
6 years, 9 months ago (2014-03-18 16:08:24 UTC) #2
reed1
https://codereview.chromium.org/203443004/diff/1/Source/platform/graphics/ImageBuffer.cpp File Source/platform/graphics/ImageBuffer.cpp (right): https://codereview.chromium.org/203443004/diff/1/Source/platform/graphics/ImageBuffer.cpp#newcode279 Source/platform/graphics/ImageBuffer.cpp:279: SkAlphaType = (multiplied == Premultiplied) ? kPremul_SkAlphaType : kUnpremul_SkAlphaType; ...
6 years, 9 months ago (2014-03-18 19:39:37 UTC) #3
reed1
The CQ bit was checked by reed@google.com
6 years, 9 months ago (2014-03-19 20:33:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reed@google.com/203443004/20001
6 years, 9 months ago (2014-03-19 20:33:25 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-19 21:07:50 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_rel
6 years, 9 months ago (2014-03-19 21:07:51 UTC) #7
reed1
The CQ bit was checked by reed@google.com
6 years, 9 months ago (2014-03-21 16:55:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reed@google.com/203443004/40001
6 years, 9 months ago (2014-03-21 16:55:51 UTC) #9
commit-bot: I haz the power
6 years, 9 months ago (2014-03-21 18:06:34 UTC) #10
Message was sent while issue was closed. 
Change committed as 169754

Powered by Google App Engine
This is Rietveld 408576698