Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1734)

Unified Diff: chrome/test/BUILD.gn

Issue 2034413003: Delete the non-static CLD data source logic. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address thakis@'s comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/BUILD.gn
diff --git a/chrome/test/BUILD.gn b/chrome/test/BUILD.gn
index 2239270e9c95c7ece427aa3eb9ed8af606c1e544..74dbad925dfb5b23743dcdb66b2a4649a83d9e65 100644
--- a/chrome/test/BUILD.gn
+++ b/chrome/test/BUILD.gn
@@ -389,7 +389,6 @@ if (!is_android) {
"//sync",
"//testing/gmock",
"//testing/gtest",
- "//third_party/cld_2:cld2_platform_impl",
"//third_party/hunspell",
"//third_party/icu",
"//third_party/libpng",
@@ -932,7 +931,6 @@ if (!is_android) {
"//testing/gtest",
"//testing/perf",
"//third_party/cacheinvalidation",
- "//third_party/cld_2:cld2_platform_impl",
"//third_party/icu",
"//third_party/leveldatabase",
"//third_party/libjingle",
@@ -1454,10 +1452,6 @@ if (!is_android) {
"//testing/gmock",
"//testing/gtest",
"//third_party/WebKit/public:blink",
-
- # Language detection is irrelevant to sync, so it can depend on any
- # implementation for CLD2. Dynamic is smaller, so go with dynamic.
- "//third_party/cld_2:cld2_dynamic",
"//third_party/icu",
"//third_party/leveldatabase",
]
@@ -1534,10 +1528,6 @@ if (!is_android) {
"//sync",
"//testing/gmock",
"//testing/gtest",
-
- # Language detection is irrelevant to sync, so it can depend on any
- # implementation for CLD2. Dynamic is smaller, so go with dynamic.
- "//third_party/cld_2:cld2_dynamic",
]
if (is_mac) {
@@ -1723,10 +1713,6 @@ test("unit_tests") {
"//google_apis",
"//skia",
"//third_party/cacheinvalidation",
-
- # Unit tests should be independent of the CLD2 access mechanism, just use
- # static for simplicity.
- "//third_party/cld_2:cld2_static",
"//third_party/icu",
"//third_party/libxml",
"//ui/base:test_support",
@@ -2308,7 +2294,6 @@ if (!is_android) {
"//chrome/child",
"//components/crash/core/common",
"//components/flags_ui:switches",
- "//third_party/cld_2:cld2_platform_impl",
"//third_party/kasko:kasko_features",
]
}
@@ -2338,7 +2323,6 @@ if (!is_android && !is_ios && !is_chromecast) {
"//testing/gmock",
"//testing/gtest",
"//testing/perf",
- "//third_party/cld_2:cld2_platform_impl",
]
if (is_win) {

Powered by Google App Engine
This is Rietveld 408576698