remoting/host/policy_watcher_unittest.cc - Issue 2034393004: Allow multiple logging::LogMessage{Handler,Listener}s

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/host/policy_watcher_unittest.cc

Issue 2034393004: Allow multiple logging::LogMessage{Handler,Listener}s Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments, deque for listeners, reentrant test Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: remoting/host/policy_watcher_unittest.cc

diff --git a/remoting/host/policy_watcher_unittest.cc b/remoting/host/policy_watcher_unittest.cc

index 9ef5cc9349941be0a854e40ed8d87beea2b5fc05..e07207f56fbcb2bbd0d498c0fe06e7b0e9a0cc06 100644

--- a/remoting/host/policy_watcher_unittest.cc

+++ b/remoting/host/policy_watcher_unittest.cc

@@ -433,9 +433,6 @@ TEST_P(MisspelledPolicyTest, WarningLogged) {

const char* misspelled_policy_name = GetParam();

base::test::MockLog mock_log;

- ON_CALL(mock_log, Log(testing::_, testing::_, testing::_, testing::_,

- testing::_)).WillByDefault(testing::Return(true));

EXPECT_CALL(mock_log,

Log(logging::LOG_WARNING, testing::_, testing::_, testing::_,

testing::HasSubstr(misspelled_policy_name))).Times(1);