Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(799)

Unified Diff: content/gpu/gpu_main.cc

Issue 2034393004: Allow multiple logging::LogMessage{Handler,Listener}s Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: use ReadWriteLock, add comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/gpu/gpu_main.cc
diff --git a/content/gpu/gpu_main.cc b/content/gpu/gpu_main.cc
index c1077998dca9b3a55de2c1911b52ebcae9f1ed6f..93a140fa4c8bffeceff818f157a9e00607ace68d 100644
--- a/content/gpu/gpu_main.cc
+++ b/content/gpu/gpu_main.cc
@@ -120,15 +120,24 @@ bool StartSandboxWindows(const sandbox::SandboxInterfaceInfo*);
base::LazyInstance<GpuChildThread::DeferredMessages> deferred_messages =
LAZY_INSTANCE_INITIALIZER;
-bool GpuProcessLogMessageHandler(int severity,
- const char* file, int line,
- size_t message_start,
- const std::string& str) {
+class GpuMainLogMessageListener : logging::LogMessageListener {
+ public:
+ void OnMessage(int severity,
+ const char* file,
+ int line,
+ size_t message_start,
+ const std::string& str) override;
+};
+
+void GpuMainLogMessageListener::OnMessage(int severity,
+ const char* file,
+ int line,
+ size_t message_start,
+ const std::string& str) {
std::string header = str.substr(0, message_start);
std::string message = str.substr(message_start);
deferred_messages.Get().push(
new GpuHostMsg_OnLogMessage(severity, header, message));
- return false;
}
} // namespace anonymous
@@ -166,7 +175,7 @@ int GpuMain(const MainFunctionParams& parameters) {
#endif
- logging::SetLogMessageHandler(GpuProcessLogMessageHandler);
+ auto log_listener = base::MakeUnique<GpuMainLogMessageListener>();
if (command_line.HasSwitch(switches::kSupportsDualGpus)) {
std::string types = command_line.GetSwitchValueASCII(
@@ -385,7 +394,7 @@ int GpuMain(const MainFunctionParams& parameters) {
dead_on_arrival = true;
}
- logging::SetLogMessageHandler(NULL);
+ log_listener.reset();
std::unique_ptr<gpu::GpuMemoryBufferFactory> gpu_memory_buffer_factory;
if (gpu::GetNativeGpuMemoryBufferType() != gfx::EMPTY_BUFFER)

Powered by Google App Engine
This is Rietveld 408576698