Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3290)

Unified Diff: chrome/browser/safe_browsing/safe_browsing_database_unittest.cc

Issue 2034393004: Allow multiple logging::LogMessage{Handler,Listener}s Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: use ReadWriteLock, add comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/safe_browsing_database_unittest.cc
diff --git a/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc b/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc
index 846f36026718769fce4d358fa32f3aaa6c505a93..3e78a80bdadd0013bfeb6d02d4c108db0500d16a 100644
--- a/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc
+++ b/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc
@@ -213,20 +213,12 @@ std::unique_ptr<SBChunkData> AddChunkHashedIpValue(int chunk_number,
// Prevent DCHECK from killing tests.
// TODO(shess): Pawel disputes the use of this, so the test which uses
// it is DISABLED. http://crbug.com/56448
-class ScopedLogMessageIgnorer {
- public:
- ScopedLogMessageIgnorer() {
- logging::SetLogMessageHandler(&LogMessageIgnorer);
- }
- ~ScopedLogMessageIgnorer() {
- // TODO(shess): Would be better to verify whether anyone else
- // changed it, and then restore it to the previous value.
- logging::SetLogMessageHandler(NULL);
- }
-
- private:
- static bool LogMessageIgnorer(int severity, const char* file, int line,
- size_t message_start, const std::string& str) {
+class ScopedLogMessageIgnorer : logging::LogMessageHandler {
+ bool OnMessage(int severity,
+ const char* file,
+ int line,
+ size_t message_start,
+ const std::string& str) override {
// Intercept FATAL, strip the stack backtrace, and log it without
// the crash part.
if (severity == logging::LOG_FATAL) {

Powered by Google App Engine
This is Rietveld 408576698