| Index: base/trace_event/trace_event_unittest.cc
|
| diff --git a/base/trace_event/trace_event_unittest.cc b/base/trace_event/trace_event_unittest.cc
|
| index ff8ec2de78880d93f521dce452c719965af25151..4d41838ceb88561dfa3272942d263a819a5ff7d5 100644
|
| --- a/base/trace_event/trace_event_unittest.cc
|
| +++ b/base/trace_event/trace_event_unittest.cc
|
| @@ -3037,18 +3037,18 @@ TEST_F(TraceEventTestFixture, ThreadOnceBlocking) {
|
| }
|
|
|
| std::string* g_log_buffer = NULL;
|
| -bool MockLogMessageHandler(int, const char*, int, size_t,
|
| - const std::string& str) {
|
| - if (!g_log_buffer)
|
| - g_log_buffer = new std::string();
|
| - g_log_buffer->append(str);
|
| - return false;
|
| -}
|
| +class MockLogMessageListener : logging::LogMessageListener {
|
| + public:
|
| + void OnMessage(int severity, const char* file, int line,
|
| + size_t message_start, const std::string& str) override {
|
| + if (!g_log_buffer)
|
| + g_log_buffer = new std::string();
|
| + g_log_buffer->append(str);
|
| + }
|
| +};
|
|
|
| TEST_F(TraceEventTestFixture, EchoToConsole) {
|
| - logging::LogMessageHandlerFunction old_log_message_handler =
|
| - logging::GetLogMessageHandler();
|
| - logging::SetLogMessageHandler(MockLogMessageHandler);
|
| + MockLogMessageListener l;
|
|
|
| TraceLog::GetInstance()->SetEnabled(
|
| TraceConfig(kRecordAllCategoryFilter, ECHO_TO_CONSOLE),
|
| @@ -3071,20 +3071,19 @@ TEST_F(TraceEventTestFixture, EchoToConsole) {
|
|
|
| EndTraceAndFlush();
|
| delete g_log_buffer;
|
| - logging::SetLogMessageHandler(old_log_message_handler);
|
| g_log_buffer = NULL;
|
| }
|
|
|
| -bool LogMessageHandlerWithTraceEvent(int, const char*, int, size_t,
|
| - const std::string&) {
|
| - TRACE_EVENT0("log", "trace_event");
|
| - return false;
|
| -}
|
| +class LogMessageListenerWithTraceEvent : logging::LogMessageListener {
|
| + public:
|
| + void OnMessage(int severity, const char* file, int line,
|
| + size_t message_start, const std::string& str) override {
|
| + TRACE_EVENT0("log", "trace_event");
|
| + }
|
| +};
|
|
|
| TEST_F(TraceEventTestFixture, EchoToConsoleTraceEventRecursion) {
|
| - logging::LogMessageHandlerFunction old_log_message_handler =
|
| - logging::GetLogMessageHandler();
|
| - logging::SetLogMessageHandler(LogMessageHandlerWithTraceEvent);
|
| + LogMessageListenerWithTraceEvent l;
|
|
|
| TraceLog::GetInstance()->SetEnabled(
|
| TraceConfig(kRecordAllCategoryFilter, ECHO_TO_CONSOLE),
|
| @@ -3095,7 +3094,6 @@ TEST_F(TraceEventTestFixture, EchoToConsoleTraceEventRecursion) {
|
| }
|
|
|
| EndTraceAndFlush();
|
| - logging::SetLogMessageHandler(old_log_message_handler);
|
| }
|
|
|
| TEST_F(TraceEventTestFixture, TimeOffset) {
|
|
|