Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(831)

Unified Diff: remoting/client/plugin/chromoting_instance.h

Issue 2034393004: Allow multiple logging::LogMessage{Handler,Listener}s Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: clean up, MockLog uses listener Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/client/plugin/chromoting_instance.h
diff --git a/remoting/client/plugin/chromoting_instance.h b/remoting/client/plugin/chromoting_instance.h
index 2d2043afefe4a352276149a505a97e13c12e2970..62c468cf161c872649221e0b1e44ac21722b7e32 100644
--- a/remoting/client/plugin/chromoting_instance.h
+++ b/remoting/client/plugin/chromoting_instance.h
@@ -136,12 +136,12 @@ class ChromotingInstance : public ClientUserInterface,
void OnVideoFrameDirtyRegion(
const webrtc::DesktopRegion& dirty_region) override;
- // Registers a global log message handler that redirects the log output to
+ // Registers a global log message listener that redirects the log output to
// our plugin instance.
// This is called by the plugin's PPP_InitializeModule.
// Note that no logging will be processed unless a ChromotingInstance has been
// registered for logging (see RegisterLoggingInstance).
- static void RegisterLogMessageHandler();
+ static void RegisterLogMessageListener();
// Registers this instance so it processes messages sent by the global log
// message handler. This overwrites any previously registered instance.
@@ -152,10 +152,10 @@ class ChromotingInstance : public ClientUserInterface,
// then the currently registered instance will stay in effect.
void UnregisterLoggingInstance();
- // A Log Message Handler that is called after each LOG message has been
- // processed. This must be of type LogMessageHandlerFunction defined in
+ // A Log Message Listener that is called after each LOG message has been
+ // processed. This must be of type LogMessageListenerFunction defined in
// base/logging.h.
- static bool LogToUI(int severity, const char* file, int line,
+ static void LogToUI(int severity, const char* file, int line,
size_t message_start, const std::string& str);
// Requests the webapp to fetch a third-party token.

Powered by Google App Engine
This is Rietveld 408576698