Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(683)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/test/gtest_util.h

Issue 2034393004: Allow multiple logging::LogMessage{Handler,Listener}s Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: clean up, MockLog uses listener Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/installer/util/installation_validation_helper.cc ('K') | « ios/chrome/browser/crash_report/breakpad_helper.mm ('k') | net/tools/stress_cache/stress_cache.cc » ('j') | remoting/host/native_messaging/log_message_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/test/gtest_util.h
diff --git a/net/test/gtest_util.h b/net/test/gtest_util.h
index f8b4cf573c287648c6e8be25c4e8ba05b304718b..056024b8f1fba852381f7a6d7810a91bfc1adc97 100644
--- a/net/test/gtest_util.h
+++ b/net/test/gtest_util.h
@@ -45,10 +45,9 @@ MATCHER(IsOk,
::net::test::ScopedDisableExitOnDFatal gtest_disable_exit; \
using ::testing::_; \
EXPECT_CALL(gtest_log, Log(_, _, _, _, _)) \
- .WillRepeatedly(::testing::Return(false)); \
+ .Times(::testing::AtLeast(0)); \
EXPECT_CALL(gtest_log, Log(logging::LOG_DFATAL, _, _, _, matcher)) \
- .Times(::testing::AtLeast(1)) \
- .WillOnce(::testing::Return(false)); \
+ .Times(::testing::AtLeast(1)); \
gtest_log.StartCapturingLogs(); \
{ statement; } \
gtest_log.StopCapturingLogs(); \
« chrome/installer/util/installation_validation_helper.cc ('K') | « ios/chrome/browser/crash_report/breakpad_helper.mm ('k') | net/tools/stress_cache/stress_cache.cc » ('j') | remoting/host/native_messaging/log_message_handler.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698