Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2875)

Unified Diff: base/trace_event/trace_event_unittest.cc

Issue 2034393004: Allow multiple logging::LogMessage{Handler,Listener}s Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: clean up, MockLog uses listener Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/trace_event/trace_event_unittest.cc
diff --git a/base/trace_event/trace_event_unittest.cc b/base/trace_event/trace_event_unittest.cc
index ff8ec2de78880d93f521dce452c719965af25151..40c99591d7eba4d7253c75f53c71cb1a7ffe6146 100644
--- a/base/trace_event/trace_event_unittest.cc
+++ b/base/trace_event/trace_event_unittest.cc
@@ -3037,18 +3037,15 @@ TEST_F(TraceEventTestFixture, ThreadOnceBlocking) {
}
std::string* g_log_buffer = NULL;
-bool MockLogMessageHandler(int, const char*, int, size_t,
- const std::string& str) {
+void MockLogMessageListener(int, const char*, int, size_t,
+ const std::string& str) {
if (!g_log_buffer)
g_log_buffer = new std::string();
g_log_buffer->append(str);
- return false;
}
TEST_F(TraceEventTestFixture, EchoToConsole) {
- logging::LogMessageHandlerFunction old_log_message_handler =
- logging::GetLogMessageHandler();
- logging::SetLogMessageHandler(MockLogMessageHandler);
+ logging::ScopedLogMessageListener l(MockLogMessageListener);
TraceLog::GetInstance()->SetEnabled(
TraceConfig(kRecordAllCategoryFilter, ECHO_TO_CONSOLE),
@@ -3071,20 +3068,16 @@ TEST_F(TraceEventTestFixture, EchoToConsole) {
EndTraceAndFlush();
delete g_log_buffer;
- logging::SetLogMessageHandler(old_log_message_handler);
g_log_buffer = NULL;
}
-bool LogMessageHandlerWithTraceEvent(int, const char*, int, size_t,
+void LogMessageListenerWithTraceEvent(int, const char*, int, size_t,
const std::string&) {
TRACE_EVENT0("log", "trace_event");
- return false;
}
TEST_F(TraceEventTestFixture, EchoToConsoleTraceEventRecursion) {
- logging::LogMessageHandlerFunction old_log_message_handler =
- logging::GetLogMessageHandler();
- logging::SetLogMessageHandler(LogMessageHandlerWithTraceEvent);
+ logging::ScopedLogMessageListener l(LogMessageListenerWithTraceEvent);
TraceLog::GetInstance()->SetEnabled(
TraceConfig(kRecordAllCategoryFilter, ECHO_TO_CONSOLE),
@@ -3095,7 +3088,6 @@ TEST_F(TraceEventTestFixture, EchoToConsoleTraceEventRecursion) {
}
EndTraceAndFlush();
- logging::SetLogMessageHandler(old_log_message_handler);
}
TEST_F(TraceEventTestFixture, TimeOffset) {

Powered by Google App Engine
This is Rietveld 408576698