Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1402)

Unified Diff: chrome/browser/ui/webui/ntp/new_tab_ui_browsertest.cc

Issue 2034393004: Allow multiple logging::LogMessage{Handler,Listener}s Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/ntp/new_tab_ui_browsertest.cc
diff --git a/chrome/browser/ui/webui/ntp/new_tab_ui_browsertest.cc b/chrome/browser/ui/webui/ntp/new_tab_ui_browsertest.cc
index 0e019c935b099b00359b0daccabdb2f02aa572db..6d9bdd2f1774e880a2229ab522fc781e64f7cf7d 100644
--- a/chrome/browser/ui/webui/ntp/new_tab_ui_browsertest.cc
+++ b/chrome/browser/ui/webui/ntp/new_tab_ui_browsertest.cc
@@ -27,30 +27,32 @@ namespace {
static bool had_console_errors = false;
-bool HandleMessage(int severity,
- const char* file,
- int line,
- size_t message_start,
- const std::string& str) {
- if (severity == logging::LOG_ERROR && file && file == std::string("CONSOLE"))
- had_console_errors = true;
- return false;
-}
+class MessageListener : logging::LogMessageListener {
+ public:
+ void OnMessage(int severity,
+ const char* file,
+ int line,
+ size_t message_start,
+ const std::string& str) override {
+ if (severity == logging::LOG_ERROR && file &&
+ file == std::string("CONSOLE"))
+ had_console_errors = true;
+ }
+};
} // namespace
class NewTabUIBrowserTest : public InProcessBrowserTest {
public:
- NewTabUIBrowserTest() {
- logging::SetLogMessageHandler(&HandleMessage);
- }
-
- ~NewTabUIBrowserTest() override { logging::SetLogMessageHandler(NULL); }
+ NewTabUIBrowserTest() {}
void TearDown() override {
InProcessBrowserTest::TearDown();
ASSERT_FALSE(had_console_errors);
}
+
+ private:
+ MessageListener log_listener_;
};
// Navigate to incognito NTP. Fails if there are console errors.
« no previous file with comments | « chrome/browser/safe_browsing/safe_browsing_database_unittest.cc ('k') | chrome/test/base/web_ui_browser_test.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698