Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Unified Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 2034393004: Allow multiple logging::LogMessage{Handler,Listener}s Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/proximity_auth/logging/logging_unittest.cc ('k') | content/gpu/gpu_child_thread.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/render_frame_host_impl.cc
diff --git a/content/browser/frame_host/render_frame_host_impl.cc b/content/browser/frame_host/render_frame_host_impl.cc
index 23b5a2443085f09635bcba5302cb0923b28068c9..54f6d27e451063513a5c5a9eed864ee9c35df99e 100644
--- a/content/browser/frame_host/render_frame_host_impl.cc
+++ b/content/browser/frame_host/render_frame_host_impl.cc
@@ -963,6 +963,10 @@ void RenderFrameHostImpl::OnDidAddMessageToConsole(
if (delegate_->DidAddMessageToConsole(level, message, line_no, source_id))
return;
+ // In order for CSP violation detections in the tests to work, console
wychen 2016/11/18 21:14:00 This comment should probably move to https://crrev
+ // messages must be forwarded to logging::LogMessage().
+ // Ref: https://crbug.com/638050
+
// Pass through log level only on WebUI pages to limit console spew.
const bool is_web_ui =
HasWebUIScheme(delegate_->GetMainFrameLastCommittedURL());
« no previous file with comments | « components/proximity_auth/logging/logging_unittest.cc ('k') | content/gpu/gpu_child_thread.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698