Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Side by Side Diff: remoting/host/native_messaging/log_message_handler.cc

Issue 2034393004: Allow multiple logging::LogMessage{Handler,Listener}s Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments, deque for listeners, reentrant test Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "remoting/host/native_messaging/log_message_handler.h" 5 #include "remoting/host/native_messaging/log_message_handler.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/lazy_instance.h" 8 #include "base/lazy_instance.h"
9 #include "base/strings/string_util.h" 9 #include "base/strings/string_util.h"
10 #include "base/synchronization/lock.h" 10 #include "base/synchronization/lock.h"
(...skipping 18 matching lines...) Expand all
29 const Delegate& delegate) 29 const Delegate& delegate)
30 : delegate_(delegate), 30 : delegate_(delegate),
31 suppress_logging_(false), 31 suppress_logging_(false),
32 caller_task_runner_(base::ThreadTaskRunnerHandle::Get()), 32 caller_task_runner_(base::ThreadTaskRunnerHandle::Get()),
33 weak_ptr_factory_(this) { 33 weak_ptr_factory_(this) {
34 base::AutoLock lock(g_log_message_handler_lock.Get()); 34 base::AutoLock lock(g_log_message_handler_lock.Get());
35 if (g_log_message_handler) { 35 if (g_log_message_handler) {
36 LOG(FATAL) << "LogMessageHandler is already registered. Only one instance " 36 LOG(FATAL) << "LogMessageHandler is already registered. Only one instance "
37 << "per process is allowed."; 37 << "per process is allowed.";
38 } 38 }
39 previous_log_message_handler_ = logging::GetLogMessageHandler();
40 logging::SetLogMessageHandler(&LogMessageHandler::OnLogMessage);
41 g_log_message_handler = this; 39 g_log_message_handler = this;
42 } 40 }
43 41
44 LogMessageHandler::~LogMessageHandler() { 42 LogMessageHandler::~LogMessageHandler() {
45 base::AutoLock lock(g_log_message_handler_lock.Get()); 43 base::AutoLock lock(g_log_message_handler_lock.Get());
46 if (logging::GetLogMessageHandler() != &LogMessageHandler::OnLogMessage) {
47 LOG(FATAL) << "LogMessageHandler is not the top-most message handler. "
48 << "Cannot unregister.";
49 }
50 logging::SetLogMessageHandler(previous_log_message_handler_);
51 g_log_message_handler = nullptr; 44 g_log_message_handler = nullptr;
52 } 45 }
53 46
54 // static 47 // static
55 const char* LogMessageHandler::kDebugMessageTypeName = "_debug_log"; 48 const char* LogMessageHandler::kDebugMessageTypeName = "_debug_log";
56 49
57 // static 50 bool LogMessageHandler::OnMessage(logging::LogSeverity severity,
58 bool LogMessageHandler::OnLogMessage( 51 const char* file,
59 logging::LogSeverity severity, 52 int line,
60 const char* file, 53 size_t message_start,
61 int line, 54 const std::string& str) {
62 size_t message_start,
63 const std::string& str) {
64 base::AutoLock lock(g_log_message_handler_lock.Get()); 55 base::AutoLock lock(g_log_message_handler_lock.Get());
65 if (g_log_message_handler) { 56 if (g_log_message_handler) {
66 g_log_message_handler->PostLogMessageToCorrectThread( 57 g_log_message_handler->PostLogMessageToCorrectThread(
67 severity, file, line, message_start, str); 58 severity, file, line, message_start, str);
68 } 59 }
69 return false; 60 return false;
70 } 61 }
71 62
72 void LogMessageHandler::PostLogMessageToCorrectThread( 63 void LogMessageHandler::PostLogMessageToCorrectThread(
73 logging::LogSeverity severity, 64 logging::LogSeverity severity,
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
123 dictionary->SetString("message", message); 114 dictionary->SetString("message", message);
124 dictionary->SetString("file", file); 115 dictionary->SetString("file", file);
125 dictionary->SetInteger("line", line); 116 dictionary->SetInteger("line", line);
126 117
127 delegate_.Run(std::move(dictionary)); 118 delegate_.Run(std::move(dictionary));
128 119
129 suppress_logging_ = false; 120 suppress_logging_ = false;
130 } 121 }
131 122
132 } // namespace remoting 123 } // namespace remoting
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698