Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Side by Side Diff: ios/chrome/browser/crash_report/breakpad_helper.mm

Issue 2034393004: Allow multiple logging::LogMessage{Handler,Listener}s Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: clean up, MockLog uses listener Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ios/chrome/browser/crash_report/breakpad_helper.h" 5 #include "ios/chrome/browser/crash_report/breakpad_helper.h"
6 6
7 #import <Foundation/Foundation.h> 7 #import <Foundation/Foundation.h>
8 #include <stddef.h> 8 #include <stddef.h>
9 9
10 #include "base/auto_reset.h" 10 #include "base/auto_reset.h"
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
71 const base::StringPiece& value) { 71 const base::StringPiece& value) {
72 AddReportParameter(base::SysUTF8ToNSString(key.as_string()), 72 AddReportParameter(base::SysUTF8ToNSString(key.as_string()),
73 base::SysUTF8ToNSString(value.as_string()), true); 73 base::SysUTF8ToNSString(value.as_string()), true);
74 } 74 }
75 75
76 // Callback for base::debug::SetCrashKeyReportingFunctions 76 // Callback for base::debug::SetCrashKeyReportingFunctions
77 void ClearCrashKeyValueImpl(const base::StringPiece& key) { 77 void ClearCrashKeyValueImpl(const base::StringPiece& key) {
78 RemoveReportParameter(base::SysUTF8ToNSString(key.as_string())); 78 RemoveReportParameter(base::SysUTF8ToNSString(key.as_string()));
79 } 79 }
80 80
81 // Callback for logging::SetLogMessageHandler 81 // Callback for logging::AddLogMessageListener
82 bool FatalMessageHandler(int severity, 82 void FatalMessageListener(int severity,
83 const char* file, 83 const char* file,
84 int line, 84 int line,
85 size_t message_start, 85 size_t message_start,
86 const std::string& str) { 86 const std::string& str) {
87 // Do not handle non-FATAL. 87 // Do not handle non-FATAL.
88 if (severity != logging::LOG_FATAL) 88 if (severity != logging::LOG_FATAL)
89 return false; 89 return;
90 90
91 // In case of OOM condition, this code could be reentered when 91 // In case of OOM condition, this code could be reentered when
92 // constructing and storing the key. Using a static is not 92 // constructing and storing the key. Using a static is not
93 // thread-safe, but if multiple threads are in the process of a 93 // thread-safe, but if multiple threads are in the process of a
94 // fatal crash at the same time, this should work. 94 // fatal crash at the same time, this should work.
95 static bool guarded = false; 95 static bool guarded = false;
96 if (guarded) 96 if (guarded)
97 return false; 97 return;
98 98
99 base::AutoReset<bool> guard(&guarded, true); 99 base::AutoReset<bool> guard(&guarded, true);
100 100
101 // Only log last path component. This matches logging.cc. 101 // Only log last path component. This matches logging.cc.
102 if (file) { 102 if (file) {
103 const char* slash = strrchr(file, '/'); 103 const char* slash = strrchr(file, '/');
104 if (slash) 104 if (slash)
105 file = slash + 1; 105 file = slash + 1;
106 } 106 }
107 107
108 NSString* fatal_key = @"LOG_FATAL"; 108 NSString* fatal_key = @"LOG_FATAL";
109 NSString* fatal_value = [NSString 109 NSString* fatal_value = [NSString
110 stringWithFormat:@"%s:%d: %s", file, line, str.c_str() + message_start]; 110 stringWithFormat:@"%s:%d: %s", file, line, str.c_str() + message_start];
111 AddReportParameter(fatal_key, fatal_value, true); 111 AddReportParameter(fatal_key, fatal_value, true);
112 112
113 // Rather than including the code to force the crash here, allow the 113 // Rather than including the code to force the crash here, allow the
114 // caller to do it. 114 // caller to do it.
115 return false;
116 } 115 }
117 116
118 // Caches the uploading flag in NSUserDefaults, so that we can access the value 117 // Caches the uploading flag in NSUserDefaults, so that we can access the value
119 // in safe mode. 118 // in safe mode.
120 void CacheUploadingEnabled(bool uploading_enabled) { 119 void CacheUploadingEnabled(bool uploading_enabled) {
121 NSUserDefaults* user_defaults = [NSUserDefaults standardUserDefaults]; 120 NSUserDefaults* user_defaults = [NSUserDefaults standardUserDefaults];
122 [user_defaults setBool:uploading_enabled ? YES : NO 121 [user_defaults setBool:uploading_enabled ? YES : NO
123 forKey:kCrashReportsUploadingEnabledKey]; 122 forKey:kCrashReportsUploadingEnabledKey];
124 } 123 }
125 124
126 } // namespace 125 } // namespace
127 126
128 void Start(const std::string& channel_name) { 127 void Start(const std::string& channel_name) {
129 DCHECK(!g_crash_reporter_enabled); 128 DCHECK(!g_crash_reporter_enabled);
130 [[BreakpadController sharedInstance] start:YES]; 129 [[BreakpadController sharedInstance] start:YES];
131 base::debug::SetCrashKeyReportingFunctions(&SetCrashKeyValueImpl, 130 base::debug::SetCrashKeyReportingFunctions(&SetCrashKeyValueImpl,
132 &ClearCrashKeyValueImpl); 131 &ClearCrashKeyValueImpl);
133 logging::SetLogMessageHandler(&FatalMessageHandler); 132 logging::AddLogMessageListener(FatalMessageListener);
134 g_crash_reporter_enabled = true; 133 g_crash_reporter_enabled = true;
135 // Register channel information. 134 // Register channel information.
136 if (channel_name.length()) { 135 if (channel_name.length()) {
137 AddReportParameter(@"channel", base::SysUTF8ToNSString(channel_name), true); 136 AddReportParameter(@"channel", base::SysUTF8ToNSString(channel_name), true);
138 } 137 }
139 // Notifying the PathService on the location of the crashes so that crashes 138 // Notifying the PathService on the location of the crashes so that crashes
140 // can be displayed to the user on the about:crashes page. 139 // can be displayed to the user on the about:crashes page.
141 NSArray* cachesDirectories = NSSearchPathForDirectoriesInDomains( 140 NSArray* cachesDirectories = NSSearchPathForDirectoriesInDomains(
142 NSCachesDirectory, NSUserDomainMask, YES); 141 NSCachesDirectory, NSUserDomainMask, YES);
143 NSString* cachePath = [cachesDirectories objectAtIndex:0]; 142 NSString* cachePath = [cachesDirectories objectAtIndex:0];
(...skipping 216 matching lines...) Expand 10 before | Expand all | Expand 10 after
360 void RestoreDefaultConfiguration() { 359 void RestoreDefaultConfiguration() {
361 if (!g_crash_reporter_enabled) 360 if (!g_crash_reporter_enabled)
362 return; 361 return;
363 [[BreakpadController sharedInstance] stop]; 362 [[BreakpadController sharedInstance] stop];
364 [[BreakpadController sharedInstance] resetConfiguration]; 363 [[BreakpadController sharedInstance] resetConfiguration];
365 [[BreakpadController sharedInstance] start:NO]; 364 [[BreakpadController sharedInstance] start:NO];
366 [[BreakpadController sharedInstance] setUploadingEnabled:NO]; 365 [[BreakpadController sharedInstance] setUploadingEnabled:NO];
367 } 366 }
368 367
369 } // namespace breakpad_helper 368 } // namespace breakpad_helper
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698