Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Side by Side Diff: base/logging_win.cc

Issue 2034393004: Allow multiple logging::LogMessage{Handler,Listener}s Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: revert slow, try adding back handlers Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/logging_win.h" 5 #include "base/logging_win.h"
6 #include "base/memory/ptr_util.h"
6 #include "base/memory/singleton.h" 7 #include "base/memory/singleton.h"
7 #include <initguid.h> // NOLINT 8 #include <initguid.h> // NOLINT
8 9
9 namespace logging { 10 namespace logging {
10 11
11 using base::win::EtwEventLevel; 12 using base::win::EtwEventLevel;
12 using base::win::EtwMofEvent; 13 using base::win::EtwMofEvent;
13 14
14 DEFINE_GUID(kLogEventId, 15 DEFINE_GUID(kLogEventId,
15 0x7fe69228, 0x633e, 0x4f06, 0x80, 0xc1, 0x52, 0x7f, 0xea, 0x23, 0xe3, 0xa7); 16 0x7fe69228, 0x633e, 0x4f06, 0x80, 0xc1, 0x52, 0x7f, 0xea, 0x23, 0xe3, 0xa7);
16 17
17 LogEventProvider::LogEventProvider() : old_log_level_(LOG_NONE) { 18 LogEventProvider::LogEventProvider() : old_log_level_(LOG_NONE) {
18 } 19 }
19 20
21 LogEventProvider::~LogEventProvider() {}
22
20 LogEventProvider* LogEventProvider::GetInstance() { 23 LogEventProvider* LogEventProvider::GetInstance() {
21 return base::Singleton<LogEventProvider, base::StaticMemorySingletonTraits< 24 return base::Singleton<LogEventProvider, base::StaticMemorySingletonTraits<
22 LogEventProvider>>::get(); 25 LogEventProvider>>::get();
23 } 26 }
24 27
25 bool LogEventProvider::LogMessage(logging::LogSeverity severity, 28 bool LogEventProvider::WinLogMessageHandler::OnMessage(
26 const char* file, int line, size_t message_start, 29 logging::LogSeverity severity,
30 const char* file,
31 int line,
32 size_t message_start,
27 const std::string& message) { 33 const std::string& message) {
28 EtwEventLevel level = TRACE_LEVEL_NONE; 34 EtwEventLevel level = TRACE_LEVEL_NONE;
29 35
30 // Convert the log severity to the most appropriate ETW trace level. 36 // Convert the log severity to the most appropriate ETW trace level.
31 if (severity >= 0) { 37 if (severity >= 0) {
32 switch (severity) { 38 switch (severity) {
33 case LOG_INFO: 39 case LOG_INFO:
34 level = TRACE_LEVEL_INFORMATION; 40 level = TRACE_LEVEL_INFORMATION;
35 break; 41 break;
36 case LOG_WARNING: 42 case LOG_WARNING:
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
81 event.SetField(2, sizeof(line), &line); 87 event.SetField(2, sizeof(line), &line);
82 // The file. 88 // The file.
83 event.SetField(3, strlen(file) + 1, file); 89 event.SetField(3, strlen(file) + 1, file);
84 // And finally the message. 90 // And finally the message.
85 event.SetField(4, message.length() + 1 - message_start, 91 event.SetField(4, message.length() + 1 - message_start,
86 message.c_str() + message_start); 92 message.c_str() + message_start);
87 93
88 provider->Log(event.get()); 94 provider->Log(event.get());
89 } 95 }
90 96
91 // Don't increase verbosity in other log destinations. 97 // Don't increase verbosity in other log destinations below this handler
98 // in the handler stack.
92 if (severity < provider->old_log_level_) 99 if (severity < provider->old_log_level_)
93 return true; 100 return true;
94 101
95 return false; 102 return false;
96 } 103 }
97 104
98 void LogEventProvider::Initialize(const GUID& provider_name) { 105 void LogEventProvider::Initialize(const GUID& provider_name) {
99 LogEventProvider* provider = LogEventProvider::GetInstance(); 106 LogEventProvider* provider = LogEventProvider::GetInstance();
100 107
101 provider->set_provider_name(provider_name); 108 provider->set_provider_name(provider_name);
102 provider->Register(); 109 provider->Register();
103 110
104 // Register our message handler with logging. 111 // Register our message handler with logging.
105 SetLogMessageHandler(LogMessage); 112 provider->log_handler_ = base::MakeUnique<WinLogMessageHandler>();
106 } 113 }
107 114
108 void LogEventProvider::Uninitialize() { 115 void LogEventProvider::Uninitialize() {
109 LogEventProvider::GetInstance()->Unregister(); 116 LogEventProvider* provider = LogEventProvider::GetInstance();
117 provider->Unregister();
118 provider->log_handler_.reset();
110 } 119 }
111 120
112 void LogEventProvider::OnEventsEnabled() { 121 void LogEventProvider::OnEventsEnabled() {
113 // Grab the old log level so we can restore it later. 122 // Grab the old log level so we can restore it later.
114 old_log_level_ = GetMinLogLevel(); 123 old_log_level_ = GetMinLogLevel();
115 124
116 // Convert the new trace level to a logging severity 125 // Convert the new trace level to a logging severity
117 // and enable logging at that level. 126 // and enable logging at that level.
118 EtwEventLevel level = enable_level(); 127 EtwEventLevel level = enable_level();
119 if (level == TRACE_LEVEL_NONE || level == TRACE_LEVEL_FATAL) { 128 if (level == TRACE_LEVEL_NONE || level == TRACE_LEVEL_FATAL) {
120 SetMinLogLevel(LOG_FATAL); 129 SetMinLogLevel(LOG_FATAL);
121 } else if (level == TRACE_LEVEL_ERROR) { 130 } else if (level == TRACE_LEVEL_ERROR) {
122 SetMinLogLevel(LOG_ERROR); 131 SetMinLogLevel(LOG_ERROR);
123 } else if (level == TRACE_LEVEL_WARNING) { 132 } else if (level == TRACE_LEVEL_WARNING) {
124 SetMinLogLevel(LOG_WARNING); 133 SetMinLogLevel(LOG_WARNING);
125 } else if (level == TRACE_LEVEL_INFORMATION) { 134 } else if (level == TRACE_LEVEL_INFORMATION) {
126 SetMinLogLevel(LOG_INFO); 135 SetMinLogLevel(LOG_INFO);
127 } else if (level >= TRACE_LEVEL_VERBOSE) { 136 } else if (level >= TRACE_LEVEL_VERBOSE) {
128 // Above INFO, we enable verbose levels with negative severities. 137 // Above INFO, we enable verbose levels with negative severities.
129 SetMinLogLevel(TRACE_LEVEL_INFORMATION - level); 138 SetMinLogLevel(TRACE_LEVEL_INFORMATION - level);
130 } 139 }
131 } 140 }
132 141
133 void LogEventProvider::OnEventsDisabled() { 142 void LogEventProvider::OnEventsDisabled() {
134 // Restore the old log level. 143 // Restore the old log level.
135 SetMinLogLevel(old_log_level_); 144 SetMinLogLevel(old_log_level_);
136 } 145 }
137 146
138 } // namespace logging 147 } // namespace logging
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698