Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Side by Side Diff: third_party/WebKit/Source/web/WebPagePopupImpl.cpp

Issue 2034393003: testRunner.layoutAndPaintAsyncThen ==> testRunner.compositeAsyncThen (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 525 matching lines...) Expand 10 before | Expand all | Expand 10 after
536 536
537 m_popupClient->didClosePopup(); 537 m_popupClient->didClosePopup();
538 m_webView->cleanupPagePopup(); 538 m_webView->cleanupPagePopup();
539 } 539 }
540 540
541 LocalDOMWindow* WebPagePopupImpl::window() 541 LocalDOMWindow* WebPagePopupImpl::window()
542 { 542 {
543 return m_page->deprecatedLocalMainFrame()->localDOMWindow(); 543 return m_page->deprecatedLocalMainFrame()->localDOMWindow();
544 } 544 }
545 545
546 void WebPagePopupImpl::layoutAndPaintAsync(WebLayoutAndPaintAsyncCallback* callb ack)
547 {
548 m_layerTreeView->layoutAndPaintAsync(callback);
549 }
550
551 void WebPagePopupImpl::compositeAndReadbackAsync(WebCompositeAndReadbackAsyncCal lback* callback) 546 void WebPagePopupImpl::compositeAndReadbackAsync(WebCompositeAndReadbackAsyncCal lback* callback)
552 { 547 {
553 DCHECK(isAcceleratedCompositingActive()); 548 DCHECK(isAcceleratedCompositingActive());
554 m_layerTreeView->compositeAndReadbackAsync(callback); 549 m_layerTreeView->compositeAndReadbackAsync(callback);
555 } 550 }
556 551
557 WebPoint WebPagePopupImpl::positionRelativeToOwner() 552 WebPoint WebPagePopupImpl::positionRelativeToOwner()
558 { 553 {
559 WebRect rootWindowRect = m_webView->client()->rootWindowRect(); 554 WebRect rootWindowRect = m_webView->client()->rootWindowRect();
560 WebRect windowRect = windowRectInScreen(); 555 WebRect windowRect = windowRectInScreen();
(...skipping 20 matching lines...) Expand all
581 // A WebPagePopupImpl instance usually has two references. 576 // A WebPagePopupImpl instance usually has two references.
582 // - One owned by the instance itself. It represents the visible widget. 577 // - One owned by the instance itself. It represents the visible widget.
583 // - One owned by a WebViewImpl. It's released when the WebViewImpl ask the 578 // - One owned by a WebViewImpl. It's released when the WebViewImpl ask the
584 // WebPagePopupImpl to close. 579 // WebPagePopupImpl to close.
585 // We need them because the closing operation is asynchronous and the widget 580 // We need them because the closing operation is asynchronous and the widget
586 // can be closed while the WebViewImpl is unaware of it. 581 // can be closed while the WebViewImpl is unaware of it.
587 return adoptRef(new WebPagePopupImpl(client)).leakRef(); 582 return adoptRef(new WebPagePopupImpl(client)).leakRef();
588 } 583 }
589 584
590 } // namespace blink 585 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/web/WebPagePopupImpl.h ('k') | third_party/WebKit/Source/web/WebViewFrameWidget.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698