Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2034393002: X87: [builtins] Migrate Math.log to TurboFan. (Closed)

Created:
4 years, 6 months ago by zhengxing.li
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [builtins] Migrate Math.log to TurboFan. port f2da19fe393124c517f9949183e988e669e4f628 (r36703) original commit message: Introduce a dedicated Float64Log machine operator, that is either implemented by a direct C call or by platform specific code, i.e. using the FPU on x64 and ia32. This operator is used to implement Math.log as a proper TurboFan builtin on top of the CodeStubAssembler. Also introduce a NumberLog simplified operator on top of Float64Log and use that for the fast inline path of Math.log inside TurboFan optimized code. BUG= Committed: https://crrev.com/973823e454a97c9d41407163b2a885b1d19993dc Cr-Commit-Position: refs/heads/master@{#36727}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M src/compiler/x87/code-generator-x87.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M src/compiler/x87/instruction-codes-x87.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/x87/instruction-selector-x87.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 6 months ago (2016-06-06 02:13:02 UTC) #2
Weiliang
lgtm
4 years, 6 months ago (2016-06-06 02:37:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2034393002/1
4 years, 6 months ago (2016-06-06 02:37:55 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-06 02:58:54 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-06 03:01:22 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/973823e454a97c9d41407163b2a885b1d19993dc
Cr-Commit-Position: refs/heads/master@{#36727}

Powered by Google App Engine
This is Rietveld 408576698