Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: third_party/protobuf/proto_library.gni

Issue 2034373002: Generate the proto JSON converter for DOM distiller (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/protobuf/proto_library.gni
diff --git a/third_party/protobuf/proto_library.gni b/third_party/protobuf/proto_library.gni
index df9d657bf46aa0366f9681f45db30cc5db87fb42..ccc2919697f3b38a8736623e2f402f0ce5c9d1f9 100644
--- a/third_party/protobuf/proto_library.gni
+++ b/third_party/protobuf/proto_library.gni
@@ -148,6 +148,15 @@ template("proto_library") {
if (defined(invoker.deps)) {
deps += invoker.deps
}
+
+ if (defined(invoker.json_converter)) {
+ args += [
+ "--plugin=protoc-gen-json_converter=" +
+ rebase_path(invoker.json_converter, root_build_dir),
+ "--json_converter_out=output_dir=:$rel_out_dir",
dcheng 2016/06/14 04:27:39 Seems a bit weird to specify this here, maybe we c
wychen 2016/08/07 09:16:27 Moving all the logic to dom_distiller_js/BUILD.gn
+ ]
+ outputs += [ "$out_dir/{{source_name_part}}_json_converter.h" ]
+ }
}
source_set(target_name) {

Powered by Google App Engine
This is Rietveld 408576698