Generate the proto JSON converter for DOM distiller

third_party/dom_distiller_js/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//third_party/protobuf/proto_library.gni")
 
-config("dependent_config") {
-  include_dirs = [ "//third_party/dom_distiller_js/dist/proto_gen" ]
-}
-
 group("proto") {
   public_deps = [
     ":dom_distiller_proto",
   ]
-  public_configs = [ ":dependent_config" ]
+  deps = [
+    ":json_values_converter_tests",
+  ]
 }
 
 proto_library("dom_distiller_proto") {
   visibility = [ ":*" ]
   sources = [
     "dist/proto/dom_distiller.proto",
   ]
   proto_out_dir = "third_party/dom_distiller_js"
+  json_converter = "protoc_plugins/json_values_converter.py"

[nyquist, 2016/08/10 01:01:42]

Is there any way that setting this json_converter would automatically include
some resources? (the inputs below)

[wychen, 2016/08/10 01:15:05]

If the plugin is a native executive, we already have dependency covered since it
needs to be built first. For dynamic scripts, we might be able to use pkgutil to
generate the list, given it's python, but I don't know how thorough and general
it needs to be. Since we are the only python plugin here, we can wait for a few
more to appear before doing this optimization.

[Dirk Pranke, 2016/08/11 00:33:53]

I suggest for now you create a file-scoped variable w/ this list of files, and
just reuse that, e.g.:

protoc_plugin_files = [ ... ]

proto_library("dom_distiller_proto") {
  ...
  inputs = protoc_plugin_files
  ...
}

etc.

Also, I don't see a 'json_converter' variable in the proto_library() template.
Am I missing something?

[wychen, 2016/08/11 01:32:19]

Done
I'm using invoker.json_converter without creating a local variable. Is this the
wrong way to do things?

+
+  # Depends on protoc_plugins properly
+  inputs = [
+    "protoc_plugins/json_values_converter.py",
+    "protoc_plugins/util/__init__.py",
+    "protoc_plugins/util/plugin.py",
+    "protoc_plugins/util/plugin_protos.py",
+    "protoc_plugins/util/types.py",
+    "protoc_plugins/util/writer.py",
+  ]
 }
+
+# The purpose of json_values_converter_test_proto is to test the
+# protoc_plugins by generating the json_converter.h file.
+proto_library("json_values_converter_test_proto") {
+  visibility = [ ":*" ]
+  sources = [
+    "test_sample.proto",
+  ]
+  proto_out_dir = "third_party/dom_distiller_js"
+  json_converter = "protoc_plugins/json_values_converter.py"
+
+  # Depends on protoc_plugins properly
+  inputs = [
+    "protoc_plugins/json_values_converter.py",
+    "protoc_plugins/util/__init__.py",
+    "protoc_plugins/util/plugin.py",
+    "protoc_plugins/util/plugin_protos.py",
+    "protoc_plugins/util/types.py",
+    "protoc_plugins/util/writer.py",
+  ]
+  generate_python = false
+  generate_cc = false
+}
+
+action("json_values_converter_tests") {
+  _stamp = "$target_gen_dir/json_values_converter_tests.stamp"
+  deps = [
+    ":json_values_converter_test_proto",
+  ]
+  inputs = [
+    "test_sample_json_converter.h.golden",
+  ]
+  outputs = [
+    _stamp,
+  ]
+
+  script = "protoc_plugins/json_values_converter_tests.py"
+  args = [
+    "--stamp",
+    rebase_path(_stamp, root_build_dir),
+    rebase_path("$target_gen_dir/test_sample_json_converter.h", root_build_dir),
+    rebase_path("test_sample_json_converter.h.golden", root_build_dir),
+  ]
+}