Source/devtools/front_end/SourcesPanel.js - Issue 203433002: DevTools: Reuse _showSourceLocation for execution line changes handling in sources panel

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/SourcesPanel.js

Issue 203433002: DevTools: Reuse _showSourceLocation for execution line changes handling in sources panel (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/devtools/front_end/CodeMirrorTextEditor.js ('K') | « Source/devtools/front_end/SourceFrame.js ('k') | Source/devtools/front_end/cm/cmdevtools.css » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/devtools/front_end/SourcesPanel.js

diff --git a/Source/devtools/front_end/SourcesPanel.js b/Source/devtools/front_end/SourcesPanel.js

index 3075bcc64f4c1fa3f445e20ac3422b02640b886c..dd168c9365e01bda9b51ca4d88c7ce37b281cdaa 100644

--- a/Source/devtools/front_end/SourcesPanel.js

+++ b/Source/devtools/front_end/SourcesPanel.js

@@ -724,14 +724,7 @@ WebInspector.SourcesPanel.prototype = {

if (this._skipExecutionLineRevealing)

return;

this._skipExecutionLineRevealing = true;

- var sourceFrame = this._showFile(uiSourceCode);

- sourceFrame.revealLine(uiLocation.lineNumber);

- this._historyManager.pushNewState();

- if (sourceFrame.canEditSource())

- sourceFrame.setSelection(WebInspector.TextRange.createFromLocation(uiLocation.lineNumber, 0));

- sourceFrame.focus();

+ this._showSourceLocation(uiSourceCode, uiLocation.lineNumber, 0);

_callFrameSelected: function(event)

« Source/devtools/front_end/CodeMirrorTextEditor.js ('K') | « Source/devtools/front_end/SourceFrame.js ('k') | Source/devtools/front_end/cm/cmdevtools.css » ('j') | no next file with comments »