Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Side by Side Diff: Source/devtools/front_end/SourcesPanel.js

Issue 203433002: DevTools: Reuse _showSourceLocation for execution line changes handling in sources panel (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2008 Apple Inc. All Rights Reserved.
3 * Copyright (C) 2011 Google Inc. All rights reserved. 3 * Copyright (C) 2011 Google Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 706 matching lines...) Expand 10 before | Expand all | Expand 10 after
717 { 717 {
718 this._historyManager.updateCurrentState(); 718 this._historyManager.updateCurrentState();
719 this._clearCurrentExecutionLine(); 719 this._clearCurrentExecutionLine();
720 this._setExecutionLine(uiLocation); 720 this._setExecutionLine(uiLocation);
721 721
722 var uiSourceCode = uiLocation.uiSourceCode; 722 var uiSourceCode = uiLocation.uiSourceCode;
723 var scriptFile = this._currentUISourceCode ? this._currentUISourceCode.s criptFile() : null; 723 var scriptFile = this._currentUISourceCode ? this._currentUISourceCode.s criptFile() : null;
724 if (this._skipExecutionLineRevealing) 724 if (this._skipExecutionLineRevealing)
725 return; 725 return;
726 this._skipExecutionLineRevealing = true; 726 this._skipExecutionLineRevealing = true;
727 727 this._showSourceLocation(uiSourceCode, uiLocation.lineNumber, 0);
728 var sourceFrame = this._showFile(uiSourceCode);
729 sourceFrame.revealLine(uiLocation.lineNumber);
730 this._historyManager.pushNewState();
731
732 if (sourceFrame.canEditSource())
733 sourceFrame.setSelection(WebInspector.TextRange.createFromLocation(u iLocation.lineNumber, 0));
734 sourceFrame.focus();
735 }, 728 },
736 729
737 _callFrameSelected: function(event) 730 _callFrameSelected: function(event)
738 { 731 {
739 var callFrame = event.data; 732 var callFrame = event.data;
740 733
741 if (!callFrame) 734 if (!callFrame)
742 return; 735 return;
743 736
744 this.sidebarPanes.scopechain.update(callFrame); 737 this.sidebarPanes.scopechain.update(callFrame);
(...skipping 987 matching lines...) Expand 10 before | Expand all | Expand 10 after
1732 { 1725 {
1733 } 1726 }
1734 1727
1735 WebInspector.SourcesPanel.EditorAction.prototype = { 1728 WebInspector.SourcesPanel.EditorAction.prototype = {
1736 /** 1729 /**
1737 * @param {!WebInspector.SourcesPanel} panel 1730 * @param {!WebInspector.SourcesPanel} panel
1738 * @return {!Element} 1731 * @return {!Element}
1739 */ 1732 */
1740 button: function(panel) { } 1733 button: function(panel) { }
1741 } 1734 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698