Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 203433002: DevTools: Reuse _showSourceLocation for execution line changes handling in sources panel (Closed)

Created:
6 years, 9 months ago by vsevik
Modified:
6 years, 9 months ago
Reviewers:
lushnikov, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: Reuse _showSourceLocation for execution line changes handling in sources panel. R=lushnikov@chromium.org, lushnikov, pfeldman Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169555

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : Rewritten #

Patch Set 4 : Rebaselined and fixed highlighting after execution line changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -12 lines) Patch
M Source/devtools/front_end/CodeMirrorTextEditor.js View 1 2 3 2 chunks +5 lines, -1 line 0 comments Download
M Source/devtools/front_end/SourcesPanel.js View 1 2 2 chunks +4 lines, -10 lines 0 comments Download
M Source/devtools/front_end/cm/cmdevtools.css View 2 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
lushnikov
https://codereview.chromium.org/203433002/diff/1/Source/devtools/front_end/CodeMirrorTextEditor.js File Source/devtools/front_end/CodeMirrorTextEditor.js (right): https://codereview.chromium.org/203433002/diff/1/Source/devtools/front_end/CodeMirrorTextEditor.js#newcode763 Source/devtools/front_end/CodeMirrorTextEditor.js:763: if (!this._executionLine) what is this needed for?
6 years, 9 months ago (2014-03-18 13:22:04 UTC) #1
vsevik
On 2014/03/18 13:22:04, lushnikov wrote: > https://codereview.chromium.org/203433002/diff/1/Source/devtools/front_end/CodeMirrorTextEditor.js > File Source/devtools/front_end/CodeMirrorTextEditor.js (right): > > https://codereview.chromium.org/203433002/diff/1/Source/devtools/front_end/CodeMirrorTextEditor.js#newcode763 > ...
6 years, 9 months ago (2014-03-18 13:31:18 UTC) #2
lushnikov
The only concern is the UserAction event WebInspector.UserMetrics.UserActionNames.OpenSourceLink which semantic we will change with this ...
6 years, 9 months ago (2014-03-18 13:43:45 UTC) #3
vsevik
The CQ bit was checked by vsevik@chromium.org
6 years, 9 months ago (2014-03-19 15:30:33 UTC) #4
vsevik
The CQ bit was unchecked by vsevik@chromium.org
6 years, 9 months ago (2014-03-19 15:30:37 UTC) #5
vsevik
On 2014/03/18 13:43:45, lushnikov wrote: > The only concern is the UserAction event > WebInspector.UserMetrics.UserActionNames.OpenSourceLink ...
6 years, 9 months ago (2014-03-19 15:33:48 UTC) #6
vsevik
The CQ bit was checked by vsevik@chromium.org
6 years, 9 months ago (2014-03-19 15:33:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/203433002/60001
6 years, 9 months ago (2014-03-19 15:33:58 UTC) #8
vsevik
6 years, 9 months ago (2014-03-19 15:36:20 UTC) #9
Message was sent while issue was closed. 
Committed patchset #4 manually as r169555 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698