Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 2034313002: Fire visualviewportchanged event on window rather than document (Closed)

Created:
4 years, 6 months ago by bokan
Modified:
4 years, 6 months ago
Reviewers:
dtapuska
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fire visualviewportchanged event on window rather than document In https://codereview.chromium.org/2025393003/ I moved the visualViewport object from document onto window but forgot to move the event to fire on the window instead. BUG=595826 Committed: https://crrev.com/5c47efc932757a230a328ec252d40d1b98009b7e Cr-Commit-Position: refs/heads/master@{#398067}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M third_party/WebKit/LayoutTests/fast/dom/viewport/visualviewportchanged-event-fired.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/viewport/visualviewportchanged-event-fired-window-resized.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
bokan
4 years, 6 months ago (2016-06-06 12:26:55 UTC) #3
dtapuska
On 2016/06/06 12:26:55, bokan wrote: lgtm
4 years, 6 months ago (2016-06-06 13:22:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2034313002/1
4 years, 6 months ago (2016-06-06 13:23:21 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-06 18:20:13 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-06 18:21:59 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5c47efc932757a230a328ec252d40d1b98009b7e
Cr-Commit-Position: refs/heads/master@{#398067}

Powered by Google App Engine
This is Rietveld 408576698