Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 2034303004: Refactoring: Use in-class member initialization in EditingStyle.h (Closed)

Created:
4 years, 6 months ago by joone
Modified:
4 years, 6 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactoring: Use in-class member initialization in EditingStyle.h It allows to remove common initialization lists in constructors. BUG=none Committed: https://crrev.com/770093e33f75f22e5fc8649bf4045bd88a1673fb Cr-Commit-Position: refs/heads/master@{#398042}

Patch Set 1 #

Patch Set 2 : move the default constructor body to class #

Total comments: 1

Patch Set 3 : use the defaulted default constructor #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -17 lines) Patch
M third_party/WebKit/Source/core/editing/EditingStyle.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/EditingStyle.cpp View 1 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
joone
Hi yosin@, as you mentioned in the last review, in-class member initialization was applied to ...
4 years, 6 months ago (2016-06-04 20:00:20 UTC) #3
yosin_UTC9
lgtm w/ nit Thanks for clean up! (^=^)b https://codereview.chromium.org/2034303004/diff/20001/third_party/WebKit/Source/core/editing/EditingStyle.h File third_party/WebKit/Source/core/editing/EditingStyle.h (right): https://codereview.chromium.org/2034303004/diff/20001/third_party/WebKit/Source/core/editing/EditingStyle.h#newcode148 third_party/WebKit/Source/core/editing/EditingStyle.h:148: EditingStyle() ...
4 years, 6 months ago (2016-06-06 01:46:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2034303004/40001
4 years, 6 months ago (2016-06-06 04:18:57 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/233756)
4 years, 6 months ago (2016-06-06 10:08:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2034303004/40001
4 years, 6 months ago (2016-06-06 14:35:24 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-06 16:13:26 UTC) #13
joone
On 2016/06/06 01:46:33, Yosi_UTC9 wrote: > lgtm w/ nit > > Thanks for clean up! ...
4 years, 6 months ago (2016-06-06 16:15:42 UTC) #14
commit-bot: I haz the power
4 years, 6 months ago (2016-06-06 16:16:23 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/770093e33f75f22e5fc8649bf4045bd88a1673fb
Cr-Commit-Position: refs/heads/master@{#398042}

Powered by Google App Engine
This is Rietveld 408576698