mojo/public/tools/bindings/blink_bindings_configuration.gni - Issue 2034273002: Mojo C++ bindings: introduce mojo::WTFMap for blink bindings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/blink_bindings_configuration.gni

Issue 2034273002: Mojo C++ bindings: introduce mojo::WTFMap for blink bindings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: removed the code of adding enum key support to WTF::HashMap; which turned out to be non-trivial; wi… Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/interfaces/bindings/tests/test_wtf_types.mojom ('k') | mojo/public/tools/bindings/generators/cpp_templates/module.h.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/blink_bindings_configuration.gni

diff --git a/mojo/public/tools/bindings/blink_bindings_configuration.gni b/mojo/public/tools/bindings/blink_bindings_configuration.gni

index 29ea58aafcd60f130571c6e58a1dc7c0cdd6f2f7..ef19cc3c55ce54ed9129b43c19019e204bf961f2 100644

--- a/mojo/public/tools/bindings/blink_bindings_configuration.gni

+++ b/mojo/public/tools/bindings/blink_bindings_configuration.gni

@@ -24,15 +24,6 @@ foreach(typemap, _typemaps) {

blacklist = [

# TODO(sammc): Remove the following once |for_blink| bindings support WTF

- # maps. See https://crbug.com/583738.

- "//components/mus/public/interfaces/clipboard.mojom",

- "//components/mus/public/interfaces/window_manager.mojom",

- "//components/mus/public/interfaces/window_tree.mojom",

- "//extensions/common/api/mime_handler.mojom",

- "//mojo/public/interfaces/bindings/tests/struct_with_traits.mojom",

- "//mojo/public/interfaces/bindings/tests/test_structs.mojom",

- "//mojo/public/interfaces/bindings/tests/test_unions.mojom",

+ # maps with enum keys. See https://crbug.com/583738.

"//mojo/public/interfaces/bindings/tests/validation_test_interfaces.mojom",

- "//services/catalog/public/interfaces/catalog.mojom",

- "//services/shell/public/interfaces/capabilities.mojom",

]