mojo/public/interfaces/bindings/tests/test_structs.mojom - Issue 2034273002: Mojo C++ bindings: introduce mojo::WTFMap for blink bindings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/interfaces/bindings/tests/test_structs.mojom

Issue 2034273002: Mojo C++ bindings: introduce mojo::WTFMap for blink bindings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: removed the code of adding enum key support to WTF::HashMap; which turned out to be non-trivial; wi… Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: mojo/public/interfaces/bindings/tests/test_structs.mojom

diff --git a/mojo/public/interfaces/bindings/tests/test_structs.mojom b/mojo/public/interfaces/bindings/tests/test_structs.mojom

index f16bd6654293d617292645b4c80f0a9583c7f49d..def4f1db8deb5144d495efe96e600e1f28f09bd6 100644

--- a/mojo/public/interfaces/bindings/tests/test_structs.mojom

+++ b/mojo/public/interfaces/bindings/tests/test_structs.mojom

@@ -113,7 +113,8 @@ struct ScopedConstants {

// decoded successfully.

struct MapKeyTypes {

- map<bool, bool> f0;

+ // TODO(yzshen): WTF::HashMap doesn't support bool as key.

+ // map<bool, bool> f0;

map<int8, int8> f1;

map<uint8, uint8> f2;

map<int16, int16> f3;

« no previous file with comments | « mojo/public/cpp/bindings/wtf_map.h ('k') | mojo/public/interfaces/bindings/tests/test_wtf_types.mojom » ('j') | no next file with comments »