Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: mojo/public/cpp/bindings/map_traits.h

Issue 2034273002: Mojo C++ bindings: introduce mojo::WTFMap for blink bindings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: removed the code of adding enum key support to WTF::HashMap; which turned out to be non-trivial; wi… Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/public/cpp/bindings/lib/wtf_serialization.h ('k') | mojo/public/cpp/bindings/map_traits_standard.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/cpp/bindings/map_traits.h
diff --git a/mojo/public/cpp/bindings/map_traits.h b/mojo/public/cpp/bindings/map_traits.h
index 7aa1cbf5507cfe5a521c2e922421508ae65ada4a..01dd66d6a69a20fbcaaaf1c748e81eb4f579dd50 100644
--- a/mojo/public/cpp/bindings/map_traits.h
+++ b/mojo/public/cpp/bindings/map_traits.h
@@ -36,10 +36,12 @@ namespace mojo {
// static V& GetValue(CustomIterator& iterator);
// static const V& GetValue(CustomConstIterator& iterator);
//
-// static void Insert(CustomMap<K, V>& input,
+// // Returning false results in deserialization failure and causes the
+// // message pipe receiving it to be disconnected.
+// static bool Insert(CustomMap<K, V>& input,
// const K& key,
// V&& value);
-// static void Insert(CustomMap<K, V>& input,
+// static bool Insert(CustomMap<K, V>& input,
// const K& key,
// const V& value);
//
« no previous file with comments | « mojo/public/cpp/bindings/lib/wtf_serialization.h ('k') | mojo/public/cpp/bindings/map_traits_standard.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698