Fix more code which has shadow variables

fpdfsdk/javascript/Consts.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "fpdfsdk/javascript/Consts.h"
 
 #include "fpdfsdk/javascript/JS_Define.h"
 #include "fpdfsdk/javascript/JS_Object.h"
@@ skipping 119 matching lines @@
   GLOBAL_STRING(pRuntime, L"IDS_MONTH_INFO",
                 L"January[1] February[2] March[3] April[4] May[5] "
                 L"June[6] July[7] August[8] September[9] October[10] "
                 L"November[11] December[12] Sept[9] Jan[1] Feb[2] Mar[3] "
                 L"Apr[4] Jun[6] Jul[7] Aug[8] Sep[9] Oct[10] Nov[11] "
                 L"Dec[12]");
 
   GLOBAL_STRING(pRuntime, L"IDS_STARTUP_CONSOLE_MSG", L"** ^ _ ^ **");
 }
 
-#define GLOBAL_ARRAY(rt, name, ...)                                   \
-  {                                                                   \
-    const FX_WCHAR* values[] = {__VA_ARGS__};                         \
-    v8::Local<v8::Array> array = FXJS_NewArray((rt)->GetIsolate());   \
-    for (size_t i = 0; i < FX_ArraySize(values); ++i)                 \
-      array->Set(i, FXJS_NewString((rt)->GetIsolate(), values[i]));   \
-    rt->SetConstArray(name, array);                                   \
-    FXJS_DefineGlobalConst(                                           \
-        (rt)->GetIsolate(), (name),                                   \
-        [](const v8::FunctionCallbackInfo<v8::Value>& info) {         \
-          CJS_Runtime* pRuntime = static_cast<CJS_Runtime*>(          \
-              FXJS_GetRuntimeFromIsolate(info.GetIsolate()));         \
-          if (pRuntime)                                               \
-            info.GetReturnValue().Set(pRuntime->GetConstArray(name)); \
-        });                                                           \
+#define GLOBAL_ARRAY(rt, name, ...)                                        \
+  {                                                                        \
+    const FX_WCHAR* values[] = {__VA_ARGS__};                              \
+    v8::Local<v8::Array> array = FXJS_NewArray((rt)->GetIsolate());        \
+    for (size_t i = 0; i < FX_ArraySize(values); ++i)                      \
+      array->Set(i, FXJS_NewString((rt)->GetIsolate(), values[i]));        \
+    rt->SetConstArray(name, array);                                        \
+    FXJS_DefineGlobalConst(                                                \
+        (rt)->GetIsolate(), (name),                                        \
+        [](const v8::FunctionCallbackInfo<v8::Value>& info) {              \
+          CJS_Runtime* pLocalRuntime = static_cast<CJS_Runtime*>(          \
+              FXJS_GetRuntimeFromIsolate(info.GetIsolate()));              \
+          if (pLocalRuntime)                                               \
+            info.GetReturnValue().Set(pLocalRuntime->GetConstArray(name)); \
+        });                                                                \
   }
 
 void CJS_GlobalArrays::DefineJSObjects(CJS_Runtime* pRuntime) {
   GLOBAL_ARRAY(pRuntime, L"RE_NUMBER_ENTRY_DOT_SEP", L"[+-]?\\d*\\.?\\d*");
   GLOBAL_ARRAY(pRuntime, L"RE_NUMBER_COMMIT_DOT_SEP",
                L"[+-]?\\d+(\\.\\d+)?",  // -1.0 or -1
                L"[+-]?\\.\\d+",         // -.1
                L"[+-]?\\d+\\.");        // -1.
 
   GLOBAL_ARRAY(pRuntime, L"RE_NUMBER_ENTRY_COMMA_SEP", L"[+-]?\\d*,?\\d*");
@@ skipping 31 matching lines @@
       L"\\d{3}(\\.|[- ])?\\d{3}(\\.|[- ])?\\d{4}",               // 408 555-1234
       L"\\(\\d{3}\\)(\\.|[- ])?\\d{3}(\\.|[- ])?\\d{4}",  // (408) 555-1234
       L"011(\\.|[- \\d])*");                              // international
 
   GLOBAL_ARRAY(pRuntime, L"RE_SSN_ENTRY",
                L"\\d{0,3}(\\.|[- ])?\\d{0,2}(\\.|[- ])?\\d{0,4}");
 
   GLOBAL_ARRAY(pRuntime, L"RE_SSN_COMMIT",
                L"\\d{3}(\\.|[- ])?\\d{2}(\\.|[- ])?\\d{4}");
 }