Fix more code which has shadow variables

fpdfsdk/fsdk_baseannot.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include <algorithm>
 
 #include "core/fpdfapi/fpdf_parser/include/cpdf_array.h"
 #include "core/fpdfapi/fpdf_parser/include/cpdf_document.h"
@@ skipping 358 matching lines @@
   else
     dtStr += CFX_ByteString("+");
   memset(tempStr, 0, sizeof(tempStr));
   FXSYS_snprintf(tempStr, sizeof(tempStr) - 1, "%02d'%02u'", abs(dt.tzHour),
                  dt.tzMinute);
   dtStr += CFX_ByteString(tempStr);
   return dtStr;
 }
 
 void CPDFSDK_DateTime::ToSystemTime(FX_SYSTEMTIME& st) {
-  CPDFSDK_DateTime dt = *this;
-  time_t t = (time_t)dt;
+  time_t t = (time_t)(*this);
   struct tm* pTime = localtime(&t);
   if (pTime) {
     st.wYear = (uint16_t)pTime->tm_year + 1900;
     st.wMonth = (uint16_t)pTime->tm_mon + 1;
     st.wDay = (uint16_t)pTime->tm_mday;
     st.wDayOfWeek = (uint16_t)pTime->tm_wday;
     st.wHour = (uint16_t)pTime->tm_hour;
     st.wMinute = (uint16_t)pTime->tm_min;
     st.wSecond = (uint16_t)pTime->tm_sec;
     st.wMilliseconds = 0;
   }
 }
 
 CPDFSDK_DateTime CPDFSDK_DateTime::ToGMT() const {
-  CPDFSDK_DateTime dt = *this;
-  dt.AddSeconds(-gAfxGetTimeZoneInSeconds(dt.dt.tzHour, dt.dt.tzMinute));
-  dt.dt.tzHour = 0;
-  dt.dt.tzMinute = 0;
-  return dt;
+  CPDFSDK_DateTime new_dt = *this;
+  new_dt.AddSeconds(
+      -gAfxGetTimeZoneInSeconds(new_dt.dt.tzHour, new_dt.dt.tzMinute));
+  new_dt.dt.tzHour = 0;
+  new_dt.dt.tzMinute = 0;
+  return new_dt;
 }
 
 CPDFSDK_DateTime& CPDFSDK_DateTime::AddDays(short days) {
   if (days == 0)
     return *this;
 
   int16_t y = dt.year, yy;
   uint8_t m = dt.month;
   uint8_t d = dt.day;
   int mdays, ydays, ldays;
@@ skipping 517 matching lines @@
 
 CPDF_Page* CPDFSDK_Annot::GetPDFPage() {
   return m_pPageView ? m_pPageView->GetPDFPage() : nullptr;
 }
 
 #ifdef PDF_ENABLE_XFA
 CPDFXFA_Page* CPDFSDK_Annot::GetPDFXFAPage() {
   return m_pPageView ? m_pPageView->GetPDFXFAPage() : nullptr;
 }
 #endif  // PDF_ENABLE_XFA