chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc - Issue 2034223002: Add immediate variants of doc.write page load metrics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc

Issue 2034223002: Add immediate variants of doc.write page load metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Code comment added. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer_unittest.cc ('k') | components/page_load_metrics/browser/metrics_web_contents_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc

diff --git a/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc b/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc

index 711d340d1e3dcb71ca2df96639dce116b808a824..8596dbeac81e79ea840eb345692d396d7a548022 100644

--- a/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc

+++ b/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc

@@ -136,9 +136,6 @@ IN_PROC_BROWSER_TEST_F(MetricsWebContentsObserverBrowserTest,

histogram_tester_.ExpectTotalCount(

internal::kHistogramDocWriteBlockParseStartToFirstContentfulPaint, 1);

- histogram_tester_.ExpectTotalCount(

- internal::kHistogramDocWriteBlockReloadCount, 1);

ui_test_utils::NavigateToURL(browser(),

embedded_test_server()->GetURL("/title2.html"));