Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.h

Issue 2034223002: Add immediate variants of doc.write page load metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Code comment added. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.h
diff --git a/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.h b/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.h
index e39f9990530be40c1235c15212f4f20868e4ceba..070cf4ee84bcf2286cc8601d978ce09653243834 100644
--- a/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.h
+++ b/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.h
@@ -14,6 +14,9 @@ namespace internal {
extern const char kHistogramDocWriteParseStartToFirstContentfulPaint[];
extern const char kHistogramDocWriteBlockParseStartToFirstContentfulPaint[];
extern const char kHistogramDocWriteBlockReloadCount[];
+extern const char kHistogramDocWriteParseStartToFirstContentfulPaintImmediate[];
+extern const char
+ kHistogramDocWriteBlockParseStartToFirstContentfulPaintImmediate[];
} // namespace internal
@@ -26,6 +29,17 @@ class DocumentWritePageLoadMetricsObserver
const page_load_metrics::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& extra_info) override;
+ void OnFirstContentfulPaint(
+ const page_load_metrics::PageLoadTiming& timing,
+ const page_load_metrics::PageLoadExtraInfo& extra_info) override;
+
+ void OnParseStop(
+ const page_load_metrics::PageLoadTiming& timing,
+ const page_load_metrics::PageLoadExtraInfo& extra_info) override;
+
+ void OnLoadingBehaviorObserved(
+ const page_load_metrics::PageLoadExtraInfo& extra_info) override;
+
private:
void LogDocumentWriteEvaluatorData(
const page_load_metrics::PageLoadTiming& timing,
@@ -35,6 +49,24 @@ class DocumentWritePageLoadMetricsObserver
const page_load_metrics::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& info);
+ void LogDocumentWriteEvaluatorFirstContentfulPaint(
+ const page_load_metrics::PageLoadTiming& timing,
+ const page_load_metrics::PageLoadExtraInfo& info);
+
+ void LogDocumentWriteEvaluatorParseStop(
+ const page_load_metrics::PageLoadTiming& timing,
+ const page_load_metrics::PageLoadExtraInfo& info);
+
+ void LogDocumentWriteBlockFirstContentfulPaint(
+ const page_load_metrics::PageLoadTiming& timing,
+ const page_load_metrics::PageLoadExtraInfo& info);
+
+ void LogDocumentWriteBlockParseStop(
+ const page_load_metrics::PageLoadTiming& timing,
+ const page_load_metrics::PageLoadExtraInfo& info);
+
+ bool doc_write_block_reload_observed_;
+
DISALLOW_COPY_AND_ASSIGN(DocumentWritePageLoadMetricsObserver);
};
« no previous file with comments | « no previous file | chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698