Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2034203002: [DevTools] Improve MainThreadDebugger::memoryInfo (Closed)

Created:
4 years, 6 months ago by kozy
Modified:
4 years, 6 months ago
Reviewers:
dgozman, adamk
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org, haraken
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Improve MainThreadDebugger::memoryInfo Use context->Global() instead of CreationContext in MainThreadDebugger::memoryInfo. BUG=616225 R=adamk@chromium.org,dgozman@chromium.org Committed: https://crrev.com/6c932f8010646f4cc13985d05e3cc75f29ea2abb Cr-Commit-Position: refs/heads/master@{#397887}

Patch Set 1 #

Patch Set 2 : added a test #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : #

Messages

Total messages: 15 (6 generated)
kozy
Dmitry and Adam, please take a look!
4 years, 6 months ago (2016-06-03 19:14:22 UTC) #1
adamk
I'll mostly defer to dgozman here, but it would be great to have a regression ...
4 years, 6 months ago (2016-06-03 19:21:18 UTC) #2
dgozman
Fix lgtm. Let's add a test. Let's also ask the author of V8WrapperInstantiationScope::securityCheck.
4 years, 6 months ago (2016-06-03 21:06:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2034203002/20001
4 years, 6 months ago (2016-06-03 23:47:23 UTC) #6
dgozman
https://codereview.chromium.org/2034203002/diff/20001/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-console-memory.html File third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-console-memory.html (right): https://codereview.chromium.org/2034203002/diff/20001/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-console-memory.html#newcode15 third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-console-memory.html:15: console.log(memory.constructor.constructor("return document.body.innerHTML")()); document.querySelector("#mydiv").textContent
4 years, 6 months ago (2016-06-03 23:59:08 UTC) #7
kozy
All done! https://codereview.chromium.org/2034203002/diff/20001/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-console-memory.html File third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-console-memory.html (right): https://codereview.chromium.org/2034203002/diff/20001/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-console-memory.html#newcode15 third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-console-memory.html:15: console.log(memory.constructor.constructor("return document.body.innerHTML")()); On 2016/06/03 23:59:07, dgozman wrote: ...
4 years, 6 months ago (2016-06-04 00:13:27 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2034203002/60001
4 years, 6 months ago (2016-06-04 00:14:06 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 6 months ago (2016-06-04 01:52:09 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-04 01:55:05 UTC) #15
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/6c932f8010646f4cc13985d05e3cc75f29ea2abb
Cr-Commit-Position: refs/heads/master@{#397887}

Powered by Google App Engine
This is Rietveld 408576698