Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2034183002: [mojo-edk] Add some buffer checks and fix UAF on NodeChannel (Closed)

Created:
4 years, 6 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

[mojo-edk] Add some buffer checks and fix UAF on NodeChannel Adds message sanity checks at the dispatcher layer for message and data pipes. Also eliminates potential UAFs on NodeChannel by ensuring it stays alive through any delegate calls which might have otherwise deleted it. BUG=613698 Review-Url: https://codereview.chromium.org/2004763002 Cr-Commit-Position: refs/heads/master@{#395373} (cherry picked from commit 99a83d5bc1df0c4d6d660dedf45c9b0e14a9df3f) Committed: https://chromium.googlesource.com/chromium/src/+/76fe408535f6fb2323f366fd2cc1d4d925863a72

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -16 lines) Patch
M mojo/edk/system/data_pipe_consumer_dispatcher.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M mojo/edk/system/data_pipe_producer_dispatcher.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M mojo/edk/system/message_pipe_dispatcher.cc View 6 chunks +39 lines, -14 lines 0 comments Download
M mojo/edk/system/node_channel.cc View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Ken Rockot(use gerrit already)
4 years, 6 months ago (2016-06-03 19:06:57 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
76fe408535f6fb2323f366fd2cc1d4d925863a72.

Powered by Google App Engine
This is Rietveld 408576698