Remove unnecessary function ChromeExtensionChooserDialog::web_contents()

Remove unnecessary function ChromeExtensionChooserDialog::web_contents()

It seems that the ChromeExtensionChooserDialog::web_contents() is not
necessary, so this CL just removed it.

BUG=613638, 577170
Committed: https://crrev.com/0ef0cd4b19a045d8eb0960d4bac0da519c138f8f
Cr-Commit-Position: refs/heads/master@{#399247}

[juncai, 2016-06-03 18:07:34]

juncai@chromium.org changed reviewers:
+ reillyg@chromium.org, rsesek@chromium.org

[juncai, 2016-06-03 18:07:35]

reillyg@chromium.org: Please review changes in 
//chrome/browser/extensions/chrome_extension_chooser_dialog.h

rsesek@chromium.org: Please review changes in 
//chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa.mm

[juncai, 2016-06-03 18:08:14]

Description was changed from

==========
Remove unnecessary function web_contents() at ChromeExtensionChooserDialog

It seems that the ChromeExtensionChooserDialog::web_contents() is not
necessary, so this CL just removed it.

BUG=613638, 577170
==========

to

==========
Remove unnecessary function ChromeExtensionChooserDialog::web_contents()

It seems that the ChromeExtensionChooserDialog::web_contents() is not
necessary, so this CL just removed it.

BUG=613638, 577170
==========

[Robert Sesek, 2016-06-03 18:09:37]

lgtm

[Reilly Grant (use Gerrit), 2016-06-03 18:33:09]

lgtm though you won't be able to land this until ShowDialog is implemented on
all platforms.

Alternatively, you could just make ShowDialog a static function that takes a
WebContents* since an instance of this class doesn't really do anything.

[juncai, 2016-06-10 19:03:25]

On 2016/06/03 18:33:09, Reilly Grant wrote:
> lgtm though you won't be able to land this until ShowDialog is implemented on
> all platforms.
> 
> Alternatively, you could just make ShowDialog a static function that takes a
> WebContents* since an instance of this class doesn't really do anything.

The ShowDialog implemented for non-Mac was done.
Also added a ShowDialogImpl() function and will do something similar as:
https://cs.chromium.org/chromium/src/chrome/browser/extensions/api/chrome_dev...
which is a workaround for MacViews.

[juncai, 2016-06-10 19:03:39]

The CQ bit was checked by juncai@chromium.org

[juncai, 2016-06-10 19:03:39]

The patchset sent to the CQ was uploaded after l-g-t-m from rsesek@chromium.org,
reillyg@chromium.org
Link to the patchset: https://codereview.chromium.org/2034163002/#ps40001
(title: "removed web_contents() accessor")

[commit-bot: I haz the power, 2016-06-10 19:04:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2034163002/40001

[commit-bot: I haz the power, 2016-06-10 19:10:02]

Description was changed from

==========
Remove unnecessary function ChromeExtensionChooserDialog::web_contents()

It seems that the ChromeExtensionChooserDialog::web_contents() is not
necessary, so this CL just removed it.

BUG=613638, 577170
==========

to

==========
Remove unnecessary function ChromeExtensionChooserDialog::web_contents()

It seems that the ChromeExtensionChooserDialog::web_contents() is not
necessary, so this CL just removed it.

BUG=613638, 577170
==========

[commit-bot: I haz the power, 2016-06-10 19:10:03]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-10 19:10:06]

CQ bit was unchecked

[commit-bot: I haz the power, 2016-06-10 19:11:16]

Description was changed from

==========
Remove unnecessary function ChromeExtensionChooserDialog::web_contents()

It seems that the ChromeExtensionChooserDialog::web_contents() is not
necessary, so this CL just removed it.

BUG=613638, 577170
==========

to

==========
Remove unnecessary function ChromeExtensionChooserDialog::web_contents()

It seems that the ChromeExtensionChooserDialog::web_contents() is not
necessary, so this CL just removed it.

BUG=613638, 577170

Committed: https://crrev.com/0ef0cd4b19a045d8eb0960d4bac0da519c138f8f
Cr-Commit-Position: refs/heads/master@{#399247}
==========

[commit-bot: I haz the power, 2016-06-10 19:11:17]

Patchset 3 (id:??) landed as
https://crrev.com/0ef0cd4b19a045d8eb0960d4bac0da519c138f8f
Cr-Commit-Position: refs/heads/master@{#399247}