content/renderer/media/android/renderer_surface_view_manager.h - Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/android/renderer_surface_view_manager.h

Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/media/android/renderer_media_session_manager.cc ('k') | content/renderer/media/android/renderer_surface_view_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/android/renderer_surface_view_manager.h

diff --git a/content/renderer/media/android/renderer_surface_view_manager.h b/content/renderer/media/android/renderer_surface_view_manager.h

index 7022744bae178ba1c6bf857630ef6fde3efedab1..f2918f3787751a0789581a557e8b68bc8b098df2 100644

--- a/content/renderer/media/android/renderer_surface_view_manager.h

+++ b/content/renderer/media/android/renderer_surface_view_manager.h

@@ -33,6 +33,9 @@ class CONTENT_EXPORT RendererSurfaceViewManager : public media::SurfaceManager,

void NaturalSizeChanged(const gfx::Size& size) override;

private:

+ // RenderFrameObserver implementation.

+ void OnDestruct() override;

void OnFullscreenSurfaceCreated(int surface_id);

// Set when a surface request is in progress.