content/renderer/image_downloader/image_downloader_impl.h - Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/image_downloader/image_downloader_impl.h

Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/image_downloader/image_downloader_impl.h

diff --git a/content/renderer/image_downloader/image_downloader_impl.h b/content/renderer/image_downloader/image_downloader_impl.h

index 07ba01516fc581845bf8f60fab56958ce13f355c..366a203ac1ae5117948a5e32be32de9e4261a83f 100644

--- a/content/renderer/image_downloader/image_downloader_impl.h

+++ b/content/renderer/image_downloader/image_downloader_impl.h

@@ -45,6 +45,9 @@ class ImageDownloaderImpl : public content::mojom::ImageDownloader,

mojo::InterfaceRequest<content::mojom::ImageDownloader> request);

~ImageDownloaderImpl() override;

+ // RenderFrameObserver implementation.

+ void OnDestruct() override;

// ImageDownloader methods:

void DownloadImage(const mojo::String& url,

bool is_favicon,

« no previous file with comments | « content/renderer/idle_user_detector.cc ('k') | content/renderer/image_downloader/image_downloader_impl.cc » ('j') | no next file with comments »