Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Unified Diff: content/renderer/devtools/devtools_client.cc

Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/devtools/devtools_client.h ('k') | content/renderer/dom_serializer_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/devtools/devtools_client.cc
diff --git a/content/renderer/devtools/devtools_client.cc b/content/renderer/devtools/devtools_client.cc
index 3f9612938248ba0dffbf37410fdb090d88c1f9cd..edc31a3f368000e9f1a39e592d4084a0801b2eb9 100644
--- a/content/renderer/devtools/devtools_client.cc
+++ b/content/renderer/devtools/devtools_client.cc
@@ -39,6 +39,10 @@ void DevToolsClient::DidClearWindowObject() {
render_frame()->ExecuteJavaScript(base::UTF8ToUTF16(compatibility_script_));
}
+void DevToolsClient::OnDestruct() {
+ delete this;
+}
+
void DevToolsClient::sendMessageToEmbedder(const WebString& message) {
Send(new DevToolsHostMsg_DispatchOnEmbedder(routing_id(),
message.utf8()));
« no previous file with comments | « content/renderer/devtools/devtools_client.h ('k') | content/renderer/dom_serializer_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698