Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(570)

Unified Diff: content/public/renderer/render_frame_observer.h

Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/renderer/render_frame_observer.h
diff --git a/content/public/renderer/render_frame_observer.h b/content/public/renderer/render_frame_observer.h
index bf7c6eee7a7c83761e2b36af34ad002b88bee9e9..a48fa5422eba0a8e41b9ffadb7fd05e6a3faea1c 100644
--- a/content/public/renderer/render_frame_observer.h
+++ b/content/public/renderer/render_frame_observer.h
@@ -37,9 +37,10 @@ class RenderFrameImpl;
class CONTENT_EXPORT RenderFrameObserver : public IPC::Listener,
public IPC::Sender {
public:
- // By default, observers will be deleted when the RenderFrame goes away. If
- // they want to outlive it, they can override this function.
- virtual void OnDestruct();
+ // A subclass can use this to delete itself. If it does not, the subclass must
+ // always null-check each call to render_frame() becase the RenderFrame can
+ // go away at any time.
+ virtual void OnDestruct() = 0;
// Called when a Pepper plugin is created.
virtual void DidCreatePepperPlugin(RendererPpapiHost* host) {}
« no previous file with comments | « components/translate/content/renderer/translate_helper.cc ('k') | content/public/renderer/render_frame_observer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698