components/nacl/renderer/nacl_helper.h - Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/nacl/renderer/nacl_helper.h

Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/dom_distiller/content/renderer/distiller_js_render_frame_observer.cc ('k') | components/nacl/renderer/nacl_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/nacl/renderer/nacl_helper.h

diff --git a/components/nacl/renderer/nacl_helper.h b/components/nacl/renderer/nacl_helper.h

index e9030fdc9402d68741499f55869078f0132e574f..ea08a10be1c2549515b8998bba77f65b7fa0c62d 100644

--- a/components/nacl/renderer/nacl_helper.h

+++ b/components/nacl/renderer/nacl_helper.h

@@ -24,6 +24,9 @@ class NaClHelper : public content::RenderFrameObserver {

void DidCreatePepperPlugin(content::RendererPpapiHost* host) override;

private:

+ // RenderFrameObserver implementation.

+ void OnDestruct() override;

DISALLOW_COPY_AND_ASSIGN(NaClHelper);

};