content/renderer/media/midi_dispatcher.cc - Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/midi_dispatcher.cc

Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/renderer/render_view_observer.h ('K') | « content/renderer/media/midi_dispatcher.h ('k') | content/renderer/media/renderer_webmediaplayer_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/midi_dispatcher.cc

diff --git a/content/renderer/media/midi_dispatcher.cc b/content/renderer/media/midi_dispatcher.cc

index 65f42a95d442c749ef269c0a703b46607bc5a297..49fe875537c21b2475b4e3c930075ee7f6ae20f9 100644

--- a/content/renderer/media/midi_dispatcher.cc

+++ b/content/renderer/media/midi_dispatcher.cc

@@ -24,6 +24,10 @@ MidiDispatcher::MidiDispatcher(RenderFrame* render_frame)

MidiDispatcher::~MidiDispatcher() {}

+void MidiDispatcher::OnDestruct() {

+ delete this;

void MidiDispatcher::requestPermission(const WebMIDIPermissionRequest& request,

const WebMIDIOptions& options) {

if (!permission_service_.get()) {