content/renderer/stats_collection_observer.cc - Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/renderer/stats_collection_observer.cc

Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « content/renderer/stats_collection_observer.h ('k') | content/renderer/text_input_client_observer.h » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "content/renderer/stats_collection_observer.h"	5 #include "content/renderer/stats_collection_observer.h"

6	6

7 #include "base/time/time.h"	7 #include "base/time/time.h"

8 #include "content/renderer/render_view_impl.h"	8 #include "content/renderer/render_view_impl.h"

9	9

10 namespace content {	10 namespace content {

(...skipping 12 matching lines...) Expand all Loading...
23	23

24 void StatsCollectionObserver::DidStopLoading() {	24 void StatsCollectionObserver::DidStopLoading() {

25 DCHECK(stop_time_.is_null());	25 DCHECK(stop_time_.is_null());

26 stop_time_ = base::Time::Now();	26 stop_time_ = base::Time::Now();

27	27

28 // Stop observing so we don't get called again.	28 // Stop observing so we don't get called again.

29 RenderViewImpl* impl = static_cast<RenderViewImpl*>(render_view());	29 RenderViewImpl* impl = static_cast<RenderViewImpl*>(render_view());

30 impl->RemoveObserver(this);	30 impl->RemoveObserver(this);

31 }	31 }

32	32

	33 void StatsCollectionObserver::OnDestruct() {

	34 delete this;

	35 }

	36

33 } // namespace content	37 } // namespace content

OLD	NEW