Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1022)

Side by Side Diff: content/renderer/manifest/manifest_manager.h

Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_MANIFEST_MANIFEST_MANAGER_H_ 5 #ifndef CONTENT_RENDERER_MANIFEST_MANIFEST_MANAGER_H_
6 #define CONTENT_RENDERER_MANIFEST_MANIFEST_MANAGER_H_ 6 #define CONTENT_RENDERER_MANIFEST_MANIFEST_MANAGER_H_
7 7
8 #include <list> 8 #include <list>
9 #include <memory> 9 #include <memory>
10 10
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
47 void DidChangeManifest() override; 47 void DidChangeManifest() override;
48 void DidCommitProvisionalLoad(bool is_new_navigation, 48 void DidCommitProvisionalLoad(bool is_new_navigation,
49 bool is_same_page_navigation) override; 49 bool is_same_page_navigation) override;
50 50
51 private: 51 private:
52 enum ResolveState { 52 enum ResolveState {
53 ResolveStateSuccess, 53 ResolveStateSuccess,
54 ResolveStateFailure 54 ResolveStateFailure
55 }; 55 };
56 56
57 // RenderFrameObserver implementation.
58 void OnDestruct() override;
59
57 // Called when receiving a ManifestManagerMsg_RequestManifest from the browser 60 // Called when receiving a ManifestManagerMsg_RequestManifest from the browser
58 // process. 61 // process.
59 void OnHasManifest(int request_id); 62 void OnHasManifest(int request_id);
60 void OnRequestManifest(int request_id); 63 void OnRequestManifest(int request_id);
61 void OnRequestManifestComplete(int request_id, 64 void OnRequestManifestComplete(int request_id,
62 const Manifest&, 65 const Manifest&,
63 const ManifestDebugInfo&); 66 const ManifestDebugInfo&);
64 67
65 void FetchManifest(); 68 void FetchManifest();
66 void OnManifestFetchComplete(const GURL& document_url, 69 void OnManifestFetchComplete(const GURL& document_url,
(...skipping 19 matching lines...) Expand all
86 ManifestDebugInfo manifest_debug_info_; 89 ManifestDebugInfo manifest_debug_info_;
87 90
88 std::list<GetManifestCallback> pending_callbacks_; 91 std::list<GetManifestCallback> pending_callbacks_;
89 92
90 DISALLOW_COPY_AND_ASSIGN(ManifestManager); 93 DISALLOW_COPY_AND_ASSIGN(ManifestManager);
91 }; 94 };
92 95
93 } // namespace content 96 } // namespace content
94 97
95 #endif // CONTENT_RENDERER_MANIFEST_MANIFEST_MANAGER_H_ 98 #endif // CONTENT_RENDERER_MANIFEST_MANIFEST_MANAGER_H_
OLDNEW
« no previous file with comments | « content/renderer/java/gin_java_bridge_dispatcher.cc ('k') | content/renderer/manifest/manifest_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698