Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Side by Side Diff: content/renderer/devtools/devtools_client.h

Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_DEVTOOLS_DEVTOOLS_CLIENT_H_ 5 #ifndef CONTENT_RENDERER_DEVTOOLS_DEVTOOLS_CLIENT_H_
6 #define CONTENT_RENDERER_DEVTOOLS_DEVTOOLS_CLIENT_H_ 6 #define CONTENT_RENDERER_DEVTOOLS_DEVTOOLS_CLIENT_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <memory> 10 #include <memory>
(...skipping 20 matching lines...) Expand all
31 : public RenderFrameObserver, 31 : public RenderFrameObserver,
32 NON_EXPORTED_BASE(public blink::WebDevToolsFrontendClient) { 32 NON_EXPORTED_BASE(public blink::WebDevToolsFrontendClient) {
33 public: 33 public:
34 DevToolsClient(RenderFrame* main_render_frame, 34 DevToolsClient(RenderFrame* main_render_frame,
35 const std::string& compatibility_script); 35 const std::string& compatibility_script);
36 ~DevToolsClient() override; 36 ~DevToolsClient() override;
37 37
38 private: 38 private:
39 // RenderFrameObserver overrides. 39 // RenderFrameObserver overrides.
40 void DidClearWindowObject() override; 40 void DidClearWindowObject() override;
41 void OnDestruct() override;
41 42
42 // WebDevToolsFrontendClient implementation. 43 // WebDevToolsFrontendClient implementation.
43 void sendMessageToEmbedder(const blink::WebString&) override; 44 void sendMessageToEmbedder(const blink::WebString&) override;
44 45
45 bool isUnderTest() override; 46 bool isUnderTest() override;
46 47
47 void OnDispatchOnInspectorFrontend(const std::string& message, 48 void OnDispatchOnInspectorFrontend(const std::string& message,
48 uint32_t total_size); 49 uint32_t total_size);
49 50
50 std::string compatibility_script_; 51 std::string compatibility_script_;
51 std::unique_ptr<blink::WebDevToolsFrontend> web_tools_frontend_; 52 std::unique_ptr<blink::WebDevToolsFrontend> web_tools_frontend_;
52 53
53 DISALLOW_COPY_AND_ASSIGN(DevToolsClient); 54 DISALLOW_COPY_AND_ASSIGN(DevToolsClient);
54 }; 55 };
55 56
56 } // namespace content 57 } // namespace content
57 58
58 #endif // CONTENT_RENDERER_DEVTOOLS_DEVTOOLS_CLIENT_H_ 59 #endif // CONTENT_RENDERER_DEVTOOLS_DEVTOOLS_CLIENT_H_
OLDNEW
« no previous file with comments | « content/renderer/devtools/devtools_agent.cc ('k') | content/renderer/devtools/devtools_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698