Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Side by Side Diff: content/renderer/devtools/devtools_agent.h

Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_DEVTOOLS_DEVTOOLS_AGENT_H_ 5 #ifndef CONTENT_RENDERER_DEVTOOLS_DEVTOOLS_AGENT_H_
6 #define CONTENT_RENDERER_DEVTOOLS_DEVTOOLS_AGENT_H_ 6 #define CONTENT_RENDERER_DEVTOOLS_DEVTOOLS_AGENT_H_
7 7
8 #include <memory> 8 #include <memory>
9 #include <string> 9 #include <string>
10 10
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
49 blink::WebDevToolsAgent* GetWebAgent(); 49 blink::WebDevToolsAgent* GetWebAgent();
50 50
51 bool IsAttached(); 51 bool IsAttached();
52 52
53 private: 53 private:
54 friend class DevToolsAgentTest; 54 friend class DevToolsAgentTest;
55 55
56 // RenderFrameObserver implementation. 56 // RenderFrameObserver implementation.
57 bool OnMessageReceived(const IPC::Message& message) override; 57 bool OnMessageReceived(const IPC::Message& message) override;
58 void WidgetWillClose() override; 58 void WidgetWillClose() override;
59 void OnDestruct() override;
59 60
60 // WebDevToolsAgentClient implementation. 61 // WebDevToolsAgentClient implementation.
61 void sendProtocolMessage(int session_id, 62 void sendProtocolMessage(int session_id,
62 int call_id, 63 int call_id,
63 const blink::WebString& response, 64 const blink::WebString& response,
64 const blink::WebString& state) override; 65 const blink::WebString& state) override;
65 blink::WebDevToolsAgentClient::WebKitClientMessageLoop* 66 blink::WebDevToolsAgentClient::WebKitClientMessageLoop*
66 createClientMessageLoop() override; 67 createClientMessageLoop() override;
67 void willEnterDebugLoop() override; 68 void willEnterDebugLoop() override;
68 void didExitDebugLoop() override; 69 void didExitDebugLoop() override;
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
102 send_protocol_message_callback_for_test_; 103 send_protocol_message_callback_for_test_;
103 std::unique_ptr<DevToolsCPUThrottler> cpu_throttler_; 104 std::unique_ptr<DevToolsCPUThrottler> cpu_throttler_;
104 base::WeakPtrFactory<DevToolsAgent> weak_factory_; 105 base::WeakPtrFactory<DevToolsAgent> weak_factory_;
105 106
106 DISALLOW_COPY_AND_ASSIGN(DevToolsAgent); 107 DISALLOW_COPY_AND_ASSIGN(DevToolsAgent);
107 }; 108 };
108 109
109 } // namespace content 110 } // namespace content
110 111
111 #endif // CONTENT_RENDERER_DEVTOOLS_DEVTOOLS_AGENT_H_ 112 #endif // CONTENT_RENDERER_DEVTOOLS_DEVTOOLS_AGENT_H_
OLDNEW
« no previous file with comments | « content/renderer/android/renderer_date_time_picker.cc ('k') | content/renderer/devtools/devtools_agent.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698