chrome/renderer/prerender/prerenderer_client.cc - Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/renderer/prerender/prerenderer_client.cc

Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/renderer/prerender/prerenderer_client.h ('k') | chrome/renderer/safe_browsing/phishing_classifier_delegate.h » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/renderer/prerender/prerenderer_client.h"	5 #include "chrome/renderer/prerender/prerenderer_client.h"

6	6

7 #include "base/logging.h"	7 #include "base/logging.h"

8 #include "chrome/renderer/prerender/prerender_extra_data.h"	8 #include "chrome/renderer/prerender/prerender_extra_data.h"

9 #include "content/public/renderer/render_view.h"	9 #include "content/public/renderer/render_view.h"

10 #include "third_party/WebKit/public/web/WebView.h"	10 #include "third_party/WebKit/public/web/WebView.h"

(...skipping 16 matching lines...) Expand all Loading...
27	27

28 void PrerendererClient::willAddPrerender(	28 void PrerendererClient::willAddPrerender(

29 blink::WebPrerender* prerender) {	29 blink::WebPrerender* prerender) {

30 DVLOG(3) << "PrerendererClient::willAddPrerender url = "	30 DVLOG(3) << "PrerendererClient::willAddPrerender url = "

31 << prerender->url().string().utf8();	31 << prerender->url().string().utf8();

32 prerender->setExtraData(new PrerenderExtraData(++s_last_prerender_id,	32 prerender->setExtraData(new PrerenderExtraData(++s_last_prerender_id,

33 routing_id(),	33 routing_id(),

34 render_view()->GetSize()));	34 render_view()->GetSize()));

35 }	35 }

36	36

	37 void PrerendererClient::OnDestruct() {

	38 delete this;

	39 }

	40

37 } // namespace prerender	41 } // namespace prerender

OLD	NEW